New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687628 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add support for suppressing subresource filtering notifications

Project Member Reported by bmcquade@chromium.org, Feb 1 2017

Issue description

There are a few cases where we want to enable subresource filtering, but not notify the user via any UI. We should add support for disabling notifications via a field trial param.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2

commit 2a7d9f90065f9219eaee49a23d2e3c497c3f44e2
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Feb 02 16:58:57 2017

Add field trial param to suppress disallowed subresource notifications.

BUG= 687628 

Review-Url: https://codereview.chromium.org/2664283003
Cr-Commit-Position: refs/heads/master@{#447780}

[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/core/browser/subresource_filter_features_test_support.h
[modify] https://crrev.com/2a7d9f90065f9219eaee49a23d2e3c497c3f44e2/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Comment 3 Deleted

Comment 4 Deleted

Status: Fixed (was: Started)

Sign in to add a comment