New issue
Advanced search Search tips

Issue 687623 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove FeatureSwitch::easy_off_store_install

Project Member Reported by rdevlin....@chromium.org, Feb 1 2017

Issue description

FeatureSwitch::easy_off_store_install is always disabled, and only used in tests.  We should remove it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f3454a3b79fc102ebb1b71e48bedf790eaccba

commit 10f3454a3b79fc102ebb1b71e48bedf790eaccba
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Feb 06 18:22:47 2017

[Extensions] Remove FeatureSwitch::easy_off_store_install

The "easy off-store install" switch is used to determine whether or not
chrome will automatically install an extension that isn't hosted in the
webstore if the user downloads it. However, this has been disabled on
all platforms, and has no associated commandline switch or flag, so it
is permanently disabled. The only usages are in tests.

Remove the feature switch and add a lighter-weight test function to
accommodate.

Also re-enable an effectively-disabled extension browsertest (which only
ran when the easy off-store install switch was enabled - and that was
never true).

BUG= 687623 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2668863002
Cr-Commit-Position: refs/heads/master@{#448311}

[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/download/download_crx_util.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/download/download_crx_util.h
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/resources/extensions/extensions.js
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/resources/md_extensions/drop_overlay.js
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/chrome/browser/ui/webui/extensions/install_extension_handler.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/extensions/common/feature_switch.cc
[modify] https://crrev.com/10f3454a3b79fc102ebb1b71e48bedf790eaccba/extensions/common/feature_switch.h

Status: Fixed (was: Started)

Sign in to add a comment