New issue
Advanced search Search tips

Issue 687613 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Feb 2017
Cc:
olivierrobin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Sync entries do not appear in Reading List

Project Member Reported by gambard@chromium.org, Feb 1 2017 
What steps will reproduce the problem?
(1) Sign in device A and B with the same account
(2) Open Reading List on device A and make sure it has at least one unread entry
(3) Add entry on device B

What is the expected result?
Device A Reading List view should be updated with the entry added from B.

What happens instead?
The user needs to close and reopen the Reading List view to see the entry.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e0361b43828f6ed6f6b31e451bf2573a5dd012a

commit 6e0361b43828f6ed6f6b31e451bf2573a5dd012a
Author: gambard <gambard@chromium.org>
Date: Wed Feb 01 17:16:13 2017

Fix Reading List Collection View Controller

This CL fixes the test to see if a new entry was added to the ReadingListModel.

BUG= 687613 

Review-Url: https://codereview.chromium.org/2668933003
Cr-Commit-Position: refs/heads/master@{#447546}

[modify] https://crrev.com/6e0361b43828f6ed6f6b31e451bf2573a5dd012a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm

Comment 2 by gambard@chromium.org, Feb 2 2017

Status: Fixed (was: Assigned)

Comment 3 by gambard@chromium.org, Feb 2 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 2 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98432529d3fa96007ec2429a903b39e509fd8482

commit 98432529d3fa96007ec2429a903b39e509fd8482
Author: gambard <gambard@chromium.org>
Date: Thu Feb 02 08:44:02 2017

Fix Reading List Collection View Controller

This CL fixes the test to see if a new entry was added to the ReadingListModel.

BUG= 687613 

Review-Url: https://codereview.chromium.org/2674673002 .
Cr-Commit-Position: refs/branch-heads/2987@{#267}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/98432529d3fa96007ec2429a903b39e509fd8482/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm

Comment 6 by srikanthg@chromium.org, Feb 7 2017

Status: Verified (was: Fixed)
Verified
Builds: M58.0.3005.0 Dev, M57.0.2987.35
Reading list entries from Device A are displayed in Device B Reading List automatically once sync changes propagated.

Device: iPhone to iPad and iPad to iPhones
iOS: 10.3, 9.3.5

Comment 7 by pmadalla@chromium.org, Feb 8 2017 

Verified the issue in the latest beta 57.0.2987.35 beta tested on iPhone6(iOS 10) iPhone7+(iOS 10).
Reading list entries from Device A are displayed in Device B Reading List automatically once sync changes propagated.

Comment 8 by ananthak@google.com, Apr 27 2017

Components: UI>Browser>ReaderMode
►

Sign in to add a comment