New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687599 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Support cross-reference links within code at a particular git tag

Project Member Reported by wittman@chromium.org, Feb 1 2017

Issue description

The UMA sampling profiler (go/uma-sampling-profiler for Googlers) would greatly benefit from being able to link to a file at a specific release tag, to support correct source linking to older Chrome revisions.

No UI support is needed for this use case, just to be able to specify the git tag for the Chrome release in the URL, along with file and line number.
 
Putting git tags in the "rcl" URL parameter works for me:
https://cs.chromium.org/chromium/src/DEPS?rcl=16.0.909.0

What did you try that didn't work?
Nice, I hadn't tried that but it works.

Once I'm at that URL, do the cross-reference links in the code reference the same revision? I didn't see any visual indication one way or the other.

Comment 3 by emso@chromium.org, Feb 3 2017

Status: Available (was: Untriaged)
Ping: can I get an answer to the question in comment #2 about whether the cross-reference links reference the same revision?

If they do then I'm good to use the tag linking. Otherwise I'll need to wait for this to be supported.
Oops sorry.  Nope, cross-references only exist for HEAD, we don't keep their history at all.
Ah, that's too bad. Having people browsing inconsistent revisions would be super confusing, so I'll have to wait for the revision-specific cross-referencing to be supported.
Summary: Support cross-reference links within code at a particular git tag (was: Support linking to files at a particular git tag)
Updating the title to reflect the actual missing functionality.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by flyboy@chromium.org, Apr 16 2018

Status: WontFix (was: Untriaged)
infeasible

Sign in to add a comment