New issue
Advanced search Search tips

Issue 687572 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

popunder by setting window.opener

Project Member Reported by jochen@chromium.org, Feb 1 2017

Issue description

sites found a way to work around the popunder blocker by setting the window.opener.
 
Cc: a...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6004a36c9e965eedc2b83f2e034bc06afa9dd616

commit 6004a36c9e965eedc2b83f2e034bc06afa9dd616
Author: jochen <jochen@chromium.org>
Date: Sat Feb 04 00:11:40 2017

Track the original opener of a webcontents so we can rely on it for popups

BUG= 687572 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2661403003
Cr-Commit-Position: refs/heads/master@{#448116}

[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[add] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/chrome/test/data/popup_blocker/popup-window-open-noopener.html
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/browser/frame_host/frame_tree_node.h
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/6004a36c9e965eedc2b83f2e034bc06afa9dd616/content/public/browser/web_contents.h

Labels: M-57 Merge-Request-57
Status: Fixed (was: Assigned)
Which OSs is this applicable to?  Thanks.
Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
sorry for not setting all flags previously
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 5 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b50a41a06e9ca097929636e4a1a0e4901bbcafce

commit b50a41a06e9ca097929636e4a1a0e4901bbcafce
Author: Jochen Eisinger <jochen@chromium.org>
Date: Sun Feb 05 00:29:38 2017

Track the original opener of a webcontents so we can rely on it for popups

BUG= 687572 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2661403003
Cr-Commit-Position: refs/heads/master@{#448116}
(cherry picked from commit 6004a36c9e965eedc2b83f2e034bc06afa9dd616)

Review-Url: https://codereview.chromium.org/2679513002 .
Cr-Commit-Position: refs/branch-heads/2987@{#311}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[add] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/chrome/test/data/popup_blocker/popup-window-open-noopener.html
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/browser/frame_host/frame_tree_node.h
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/b50a41a06e9ca097929636e4a1a0e4901bbcafce/content/public/browser/web_contents.h

Issue 692563 has been merged into this issue.

Sign in to add a comment