New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687539 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

When history clearing is disabled by policy grey out or hide the delete link on the history page.

Project Member Reported by pastarmovj@chromium.org, Feb 1 2017

Issue description

When history clearing is disabled by policy grey out or hide the delete link on the history page.

Currently it is clickable but does nothing.
 

Comment 1 by dbeam@chromium.org, Feb 1 2017

Cc: calamity@chromium.org tsergeant@chromium.org
I think this is fixed now. When the policy is active the current master version of Chrome will not even let you click the "delete" item in the drop down meny of a single history element and selecting items is disabled too. 

@dbeam: I am right to assume this is WAI?

Do you think it makes sense to hide the selection boxes and the delete item link when this policy is active instead of making them unclickable?
Hiding these things makes sense to me.

Comment 4 by dbeam@chromium.org, Feb 8 2017

fwiw: I think the history page could do a much better job of showing disabled UI components.

after setting AllowDeletingBrowserHistory to true and reloading about:policy, I can see in the inspector (and by clicking) that checkboxes are disabled, but I didn't know that AT ALL before trying.  I'm colorblind, so maybe there is a difference in disabled look, but it's lost on me.  We should make it clearer or just remove the checkboxes (because the only 2 actions are CANCEL/DELETE right now).

We should also more clearly disable the action menu item "Remove this site" or just not show it.

MD downloads already hides the X to delete an item when this policy is disabled.

tl;dr - agree with tsergeant@.
history_action_menu.png
4.3 KB View Download
history_checkbox.png
4.7 KB View Download
downloads_no_x_to_delete.png
10.0 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment