[MD Settings] Tabstrip title doesn't change after navigating to any sub-pages.
Reported by
dchau...@etouch.net,
Feb 1 2017
|
||||||||||||||
Issue descriptionChrome Version: 56.0.2924.87 (Official Build)0e9a9a6f3676ae439b78cd9b3f62b4193c3ac7d5-refs/branch-heads/2924@{#895} 32/64-bit. OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12),Linux 14.04 What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings page. 2. Click on 'Manage search engines' option under 'Search engine' section. 3. Now, observe the tabstrip title. Tabstrip title doesn't change. Tabstrip title should get change to 'Settings-Search engines'. This is a non-regression issue, seen from ‘M 47’ series. Kindly review the attached screenshot and screen-cast for reference.
,
Sep 18
,
Dec 13
,
Dec 14
yeah, i think this would still be nice to have (more specific subpages tied to history/navigation)
,
Dec 18
Updated subpages to update the title.
,
Dec 18
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7873f189dceba7e72455d40581554cc948644d1a commit 7873f189dceba7e72455d40581554cc948644d1a Author: John Lee <johntlee@chromium.org> Date: Wed Dec 19 22:48:32 2018 Settings WebUI: Update tab title when entering subpages Bug: 687523 Change-Id: I008548a87a6e5ad453adfe75f5474c810feb8c78 Reviewed-on: https://chromium-review.googlesource.com/c/1381512 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#617991} [modify] https://crrev.com/7873f189dceba7e72455d40581554cc948644d1a/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/7873f189dceba7e72455d40581554cc948644d1a/chrome/browser/resources/settings/settings_page/settings_subpage.js [modify] https://crrev.com/7873f189dceba7e72455d40581554cc948644d1a/chrome/test/data/webui/settings/settings_main_test.js [modify] https://crrev.com/7873f189dceba7e72455d40581554cc948644d1a/chrome/test/data/webui/settings/settings_subpage_test.js
,
Dec 20
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Feb 1 2017