New issue
Advanced search Search tips

Issue 687522 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Gatekeeper e-mails should point to Milo, not BuildBot.

Project Member Reported by dsansome@chromium.org, Feb 1 2017

Issue description

Gatekeeper emails contain links to stdio on buildbot masters, but now these links (https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-32/builds/5625/steps/gclient%20runhooks/logs/stdio) have only the message "This build is configured to send log data exclusively to LogDog. Please click the LogDog link on the build page to view this log stream"
 

Comment 1 by d...@chromium.org, Feb 1 2017

Components: Infra>Platform>LogDog Infra>Platform>Milo
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Summary: Gatekeeper e-mails should point to Milo, not BuildBot. (was: Log links in gatekeeper emails are useless)
Hmm that sucks. Those links probably need to be updated to point to Milo and its build log links instead of BuildBot in general.

I'm lowering the label to P2, since Gatekeeper also links the build, and it's a trivial leap to find the log in question in the actual build information page.
Cc: martiniss@chromium.org
cc-ing myself, since I'm now the owner of gatekeeper. Not sure when I'll get to this, but I've seen it!

Comment 3 by no...@chromium.org, Mar 20 2017

Components: Infra>Platform>Milo>Buildbot

Comment 4 by no...@chromium.org, Mar 20 2017

Components: -Infra>Platform>Milo
This is annoying :(
Cc: zhangtiff@chromium.org seanmccullough@chromium.org
For the record, the template generating these emails is here:

https://cs.chromium.org/chromium/infra/appengine/chromium_build/templates/waterfall_mail.html

The data it's getting is links to buildbot. We need to replace the data it gets with links to logdog.

The data comes from here (roughly): https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper_ng.py?q=gatekeeper_ng.p+package:%5Echromium$&l=697

dnj@, how do we make a link to a logdog stream? AFAIK it should be fairly simple, any docs or examples you can point to?
dnj@ made a change to rewrite linked in Milo to the logdog URLs.  Milo hasn't rolled due to another separate issue.

Comment 9 by d...@chromium.org, Apr 4 2017

Gatekeeper uses data from Milo, right? If so, this will pick up the new Milo JSON URL change once it rolls.
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)

Sign in to add a comment