Issue metadata
Sign in to add a comment
|
You are now signed to chrome dialog box content looks so small after signing in to chrome |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.2998.0 OS: Windows- 7 & 10 (Dell Precision, Lenovo Ultrabook) What steps will reproduce the problem? (1) Open chrome (2) Click on RHS avatar icon (3) Sign in to chrome What is the expected result? You are now signed in to chrome dialog should display properly What happens instead? You are now signed in to chrome dialog display chopped and all the fonts are looking very small Note: This issue is observed only on laptop but not seen on desktop machines which is specific to screen resolution. Bisect Information: --------------------- Good build:58.0.2994.0 (446546) Bad build: 58.0.2995.0 (446928) Unable to provide tool bisect info since this issue is specific to laptop, so providing manual bisect CL as per omahaproxy. Change log: https://chromium.googlesource.com/chromium/src/+log/58.0.2994.0..58.0.2995.0?pretty=fuller&n=10000 From the above CL suspecting the below change. Review-Url: https://codereview.chromium.org/2658783004 msarda@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Feb 1 2017
Note that the CL https://codereview.chromium.org/2658783004 (attached to issue 685021 ), was merged this morning to M56 and M57, so this bug may also occur on M56 and M57. I am adding M56 and M57 milestones so that it is caught by the milestone owners and evaluate whether or not it should block the release.
,
Feb 1 2017
,
Feb 1 2017
,
Feb 1 2017
I have tried to find a clean solution that would work both for high definition screens and for the page being zoomed and failed. It looks like the default web page zoom cannot be reset in a simple manner with the ZoomController. I have added a CL to avoid resetting the zoom - CL https://codereview.chromium.org/2667113003
,
Feb 1 2017
CC+ bustamante@ Note that the CL https://codereview.chromium.org/2658783004 (attached to issue 685021 ), was merged this morning to M56 and M57, so this bug will probably also occur on M56 and M57.
,
Feb 1 2017
Hi Richard, in fixing Issue 685021 , we caused another issue (see above). Basically, the sync confirmation dialogue looks really awful on HDPI Windows laptops. It's still functional, but I'm a little concerned about having this behavior for an entire milestone for those users. Mihai has a CL in #5 that he's landing soon which fixes this issue (while still fixing Issue 685021 ). Is there any possibility we could get that fix into the 56 release candidate still, or has that ship sailed?
,
Feb 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81408d286b29382d824d1949616051f14f78719 commit d81408d286b29382d824d1949616051f14f78719 Author: msarda <msarda@chromium.org> Date: Wed Feb 01 19:56:45 2017 Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. This CL adds a hack to avoid a zoom reset problem on Windows HDPI screens. The effects are the following: 1. When the page zoom is 100% (default value), then the dialogs are corrently displayed even on high definition screens (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbbkE5RDRVbHNrbkU ) 2. when the page zoom is different than 100%, then the dialogs will be zoomed accordingly and will display scrollbars (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbYVhiM1Rya3BhRlk ). BUG= 687499 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667113003 Cr-Commit-Position: refs/heads/master@{#447584} [modify] https://crrev.com/d81408d286b29382d824d1949616051f14f78719/chrome/browser/resources/signin/signin_shared_css.html
,
Feb 1 2017
,
Feb 1 2017
We should include this fix in M-56 and M-57.
,
Feb 1 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2017
Talked with Richard offline. Unfortunately, since this doesn't really qualify as an "emergency," this isn't going to make it back into 56. Removing the labels associated with 56, and just requesting a merge back to 57.
,
Feb 2 2017
Verified this issue on Windows-10 (Dell Precision) HiDpi using chrome latest canary M58-58.0.3000.0 and observed that 'You are now signed in to chrome dialog display the contents properly' as expected. Hence adding TE-Verified label for M-58. Thanks!
,
Feb 2 2017
HDPI laptops include most Win10 laptops. :( Exposure is limited because we don't prompt Win10 users to sign in on 56, but we definitely need this for 57 when we will start prompting. If there's a 56 respin for other reasons, I'd like us to try to merge this and get it out with that.
,
Feb 2 2017
+1, would also be happy to try to get this into any respins that happen. Luckily, the dialogue is still functional (you can still click the buttons), it just looks really terrible. Let's at least merge this to 57 ASAP, and then figure out whether there's any potential for us to get into a 56 respin.
,
Feb 2 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2017
Please merge your change to M57 branch 2987 by 5:00 PM PT, Friday (02/03) so we can pick it for next week M57 Beta release. Thank you.
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf76eab2364310f3e79b6ed80074b8b25a3c1c7 commit 6cf76eab2364310f3e79b6ed80074b8b25a3c1c7 Author: Mihai Sardarescu <msarda@chromium.org> Date: Fri Feb 03 13:29:27 2017 Avoid resetting the zoom on the sync confirmation and sign-in error dialogs. This CL adds a hack to avoid a zoom reset problem on Windows HDPI screens. The effects are the following: 1. When the page zoom is 100% (default value), then the dialogs are corrently displayed even on high definition screens (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbbkE5RDRVbHNrbkU ) 2. when the page zoom is different than 100%, then the dialogs will be zoomed accordingly and will display scrollbars (screenshot: https://drive.google.com/open?id=0Bw1MJ8m7U5kbYVhiM1Rya3BhRlk ). BUG= 687499 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667113003 Cr-Commit-Position: refs/heads/master@{#447584} (cherry picked from commit d81408d286b29382d824d1949616051f14f78719) Review-Url: https://codereview.chromium.org/2670013005 . Cr-Commit-Position: refs/branch-heads/2987@{#287} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/6cf76eab2364310f3e79b6ed80074b8b25a3c1c7/chrome/browser/resources/signin/signin_shared_css.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Feb 1 2017