New issue
Advanced search Search tips

Issue 687442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT auto-import] wpt-update-expectations deleted lines in TestExpectations for un-changed tests

Project Member Reported by qyears...@chromium.org, Feb 1 2017

Issue description

Example 1: In https://codereview.chromium.org/2665073003/, this line was removed:
crbug.com/613663 external/wpt/quirks-mode/unitless-length.html [ Failure Timeout ]

Example 2: In https://codereview.chromium.org/2645553002/, this line was removed:
Bug(dpranke) external/wpt/service-workers/service-worker/fetch-event-redirect.https.html
 
Labels: -Pri-2 Pri-1
This is still an issue. Recent instance:  bug 699181 .
Another case:

An expectation for external/wpt/pointerevents/compat/pointerevent_touch-action_two-finger_interaction-manual.html was removed in https://chromium-review.googlesource.com/c/454857/2.

As of right now, I'm still not sure why this happens, but I think I could probably reproduce this by making another manual import, running wpt-update-expectations, and finding a place where it happens.
Status: Started (was: Assigned)
Here's one idea about what's happening:

When a test flakily passes, it is still fetched along with other "failing" tests at WPTExpectationsUpdater.get_failing_results_dict:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py?l=77

And then, if it's a testharness test, then in WPTExpectationsUpdater.get_tests_to_rebaseline, this test is added to the list of tests that should be rebaselined.

Then, in webkit-patch rebaseline-cl, when the passing test is rebaselined, and there are actually no new baselines to download since the test is now passing, the line is removed from TestExpectations while rebaselining.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb5a41a23dda1f926f1d724650ad63d22bb823ac

commit fb5a41a23dda1f926f1d724650ad63d22bb823ac
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Mar 17 01:29:53 2017

In wpt-update-expectations, ignore tests that unexpectedly pass.

In general, when the auto-importer is updating expectations and baselines, if a test unexpectedly passes, then it should be OK to just leave it alone and not update anything.

If the pass was a flaky pass, then the previous behavior would have been to try to rebaseline it, which would remove the expectation, which would later cause trouble if the test is flaky.

BUG= 687442 

Review-Url: https://codereview.chromium.org/2750273003
Cr-Commit-Position: refs/heads/master@{#457647}

[modify] https://crrev.com/fb5a41a23dda1f926f1d724650ad63d22bb823ac/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
[modify] https://crrev.com/fb5a41a23dda1f926f1d724650ad63d22bb823ac/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

Status: Fixed (was: Started)
Possibly fixed, will reopen if I see this again!
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment