Oops:

[1] https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java?q=org.chromium.chrome.browser.payments.PaymentRequestExpiredLocalCardTest+function:testPromptErrorMessages&l=158

Disable going through CQ now: https://codereview.chromium.org/2666253002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105ac643a506f1a5cf822d0ebca27e718c46a892

commit 105ac643a506f1a5cf822d0ebca27e718c46a892
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Jun 12 18:17:34 2017

CVC unmask dialog usability improvement.

Before this patch, hitting the software keyboard's "submit" button in
the CVC unmask dialog would hide the software keyboard and recenter the
dialog vertically. This would cause the user to hunt for the "Confirm"
button on the dialog at a new location. The user would be even more
frustrated if they instead accidentally tapped outside of the CVC
dialog, which cancels the CVC unmask.

This patch adds an editor action listener for the CVC number field in
the CVC unmask dialog. Whenever the user hits "submit" button on their
software keyboard in the CVC dialog, the listener checks if the dialog's
"confirm" button is enabled and, if so, clicks it. This patch also
changes the default software keyboard action on expiration date from
"submit" to "next field".

After this patch, hitting the software keyboard's "submit" button in the
CVC unmask dialog will perform the CVC unmask.

Bug:  730771 ,  687438 
Change-Id: Ie8d93e1df214c7fd5494dd0da64a3b94fb1861b9
Reviewed-on: https://chromium-review.googlesource.com/527500
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478685}
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/105ac643a506f1a5cf822d0ebca27e718c46a892/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java

Upgrading to P0. This test is failing on all tryjobs on linux_android_rel_ng right now:

https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/

and any change that modifies the build can't get through the CQ.

The disabling of this test apparently never succeeded. CC'ing sheriffs. Could someone please take care of this?

This is another reason that retries need to be disabled. Also has FindIt found when this started regressing?

Deleted: Screen Shot 2018-01-31 at 8.36.02 PM.png 850 KB

	Screen Shot 2018-01-31 at 8.36.02 PM.png 850 KB View Download

BTW, my failing try jobs:

https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/479908
https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/479848

Looking into this...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e5740dcac30d7c8bce859477552a1997c4f1de

commit e6e5740dcac30d7c8bce859477552a1997c4f1de
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Feb 01 12:34:39 2018

Disable PaymentRequestExpiredLocalCardTest#testPromptErrorMessages.

The test has been consistently failing on try bots since the
beginning of February.

TBR=tsergeant@chromium.org

Bug:  687438 
Change-Id: Ifc4a68d1d642777365f191c6fc5b64d153989b10
Reviewed-on: https://chromium-review.googlesource.com/897496
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533644}
[modify] https://crrev.com/e6e5740dcac30d7c8bce859477552a1997c4f1de/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java

Rouslan, you touched the test last, could you please look into what's going wrong with it and re-enable?

 Issue 807979  has been merged into this issue.

Re #7: no, Findit didn't analyze this test failure. Because those Android builders/testers seem moved from chromium.linux to chromium.android, they are not on the support whitelist anymore.

File https://bugs.chromium.org/p/chromium/issues/detail?id=808053 to add them back.

The test in question runs different code depending on whether it's January. This has broken before and usually is an easy fix. Looking into it now.

 Issue 808042  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a39316477f43dbdee1cb8f2ff21fc9b33415032

commit 7a39316477f43dbdee1cb8f2ff21fc9b33415032
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Feb 01 19:09:05 2018

[Payments] Fix integration test for expired card.

Bug:  687438 
Change-Id: If141c86a47e5455c94a3ed36b1d6d5bc95033d9f
Reviewed-on: https://chromium-review.googlesource.com/897887
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533762}
[modify] https://crrev.com/7a39316477f43dbdee1cb8f2ff21fc9b33415032/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java

Issue 808606 has been merged into this issue.