New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687407 link

Starred by 16 users
Status: Fixed
Owner:
█ dvallet@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 709836


Sign in to add a comment

Make headless work on Mac

Project Member Reported by dvallet@chromium.org, Feb 1 2017 
Feature description:

Step 1. Make headless_lib compile and run with a hidden window
Step 2. Make --headless work

Step 3. Investigate if we can use aura in Max to avoid hidden windows and have true headless
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df183ec6ada211dda086eda5b3bb940f7802ca9f

commit df183ec6ada211dda086eda5b3bb940f7802ca9f
Author: dvallet <dvallet@chromium.org>
Date: Mon Feb 13 04:49:49 2017

Remove code and minimize references to aura as to facilitate refractoring needed for Mac headless
BUG= 687407 

Review-Url: https://codereview.chromium.org/2669693002
Cr-Commit-Position: refs/heads/master@{#449909}

[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/BUILD.gn
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_browser_impl.h
[add] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_browser_impl_aura.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_browser_main_parts.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_screen.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_screen.h
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_web_contents_impl.h
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_window_tree_host.cc
[modify] https://crrev.com/df183ec6ada211dda086eda5b3bb940f7802ca9f/headless/lib/browser/headless_window_tree_host.h
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7c4939603b40622d8dbbb65ef88de5aeb72076

commit 1a7c4939603b40622d8dbbb65ef88de5aeb72076
Author: dvallet <dvallet@chromium.org>
Date: Mon Feb 27 04:39:15 2017

Enable building headless_shell in MAC. This is an initial implementation with a hidden window, rather than "true" headless.

Note: screenshot functionality is not working. This is due to screenshots on mac being created from window bounds withing the screen, so DCHECK
fails when window is hidden. See https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_mac.mm?rcl=5fa975c1785e2a47c96471691447846d1be8b51d&l=19 for actual code
BUG= 687407 

Review-Url: https://codereview.chromium.org/2712093002
Cr-Commit-Position: refs/heads/master@{#453147}

[modify] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/BUILD.gn
[add] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/lib/browser/headless_browser_impl_mac.mm
[modify] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/lib/browser/headless_content_browser_client.h
[modify] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/1a7c4939603b40622d8dbbb65ef88de5aeb72076/headless/lib/headless_content_main_delegate.h

Comment 3 by eseckler@chromium.org, Feb 27 2017 

Regarding screenshots: What we'd need to do is take them from the base layer of the RenderWidgetHostView, instead of using OS-level view screenshots.

We can't do that for Page.CaptureScreenshot on normal chrome, because people are using that for graphics integration testing. But maybe we can make Page.CaptureScreenshot work differently in headless mode (e.g. by checking for presence of the runtime flag).

Feel free to have a look at patch set 2 in the patch below, where I originally tried to move Page.CaptureScreenshot onto RWHV::CopyFromCompositingSurface().
https://codereview.chromium.org/2592983002/#ps40001

Comment 4 by dvallet@chromium.org, Feb 28 2017 

@eseckler: Thanks! I'll take a look. 
Is this something that we want to do for Mac only, or all platforms?
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1cdf374afee0df705c899ae71ec3970915f9512

commit f1cdf374afee0df705c899ae71ec3970915f9512
Author: dvallet <dvallet@chromium.org>
Date: Wed Mar 01 02:04:56 2017

Revert of Make --headless flag work on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2720863003/ )

Reason for revert:
This CL is braking Mac buildbot, when trying to build headless_example and headless_shell with component build set to false. With the following error:
AILED: headless_example headless_example.unstripped
export DEVELOPER_DIR=/b/c/b/mac/src/build/mac_files/Xcode.app;  TOOL_VERSION=1487140455 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -Wcrl,unstripped,/b/c/b/mac/src/out/Release -Werror -Wl,-dead_strip -isysroot /b/c/b/mac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-pie -Wcrl,strip,-x,-S -L../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib -o "./headless_example" -Wl,-filelist,"./headless_example.rsp"  -lbsm -framework Cocoa -framework Foundation -framework IOKit -framework Security -framework SystemConfiguration -framework ApplicationServices -framework AppKit -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework CFNetwork -framework CoreServices -lresolv -framework IOBluetooth -framework Accelerate -framework AudioUnit -framework Carbon -framework CoreVideo -framework IOSurface -framework OpenGL -framework Quartz -framework QuartzCore -framework AVFoundation -framework CoreMedia -framework AudioToolbox -framework CoreAudio -framework VideoToolbox -framework DiskArbitration -framework CoreMIDI -lsandbox -framework GameController -framework CoreWLAN -lcups
Undefined symbols for architecture x86_64:
  "content::PpapiPluginMain(content::MainFunctionParams const&)", referenced from:
      content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o
  "content::PpapiBrokerMain(content::MainFunctionParams const&)", referenced from:
      content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*)::kMainFunctions in content_main_runner.o
ld: symbol(s) not found for architecture x86_64

Original issue's description:
> Make --headless flag work on Mac
>
>
> BUG= 687407 
>
> Review-Url: https://codereview.chromium.org/2720863003
> Cr-Commit-Position: refs/heads/master@{#453778}
> Committed: https://chromium.googlesource.com/chromium/src/+/664dcbac5d9fac9223b5e273e30ee094d91489b3

TBR=skyostil@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687407 

Review-Url: https://codereview.chromium.org/2727503002
Cr-Commit-Position: refs/heads/master@{#453792}

[modify] https://crrev.com/f1cdf374afee0df705c899ae71ec3970915f9512/chrome/BUILD.gn
[modify] https://crrev.com/f1cdf374afee0df705c899ae71ec3970915f9512/chrome/app/chrome_main.cc
[modify] https://crrev.com/f1cdf374afee0df705c899ae71ec3970915f9512/headless/lib/browser/headless_content_browser_client.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a29e0ca43402988b63335e0d53a04f1fe2e61e

commit 42a29e0ca43402988b63335e0d53a04f1fe2e61e
Author: dvallet <dvallet@chromium.org>
Date: Wed Mar 01 22:34:50 2017

Rollfowrad of crrev.com/2720863003/: Make --headless flag work on Mac
Fix added child dependency in headless_lib
This is pending on splitting headless library so it can be property build in windows.
BUG= 687407 

Review-Url: https://codereview.chromium.org/2723933003
Cr-Commit-Position: refs/heads/master@{#454074}

[modify] https://crrev.com/42a29e0ca43402988b63335e0d53a04f1fe2e61e/chrome/BUILD.gn
[modify] https://crrev.com/42a29e0ca43402988b63335e0d53a04f1fe2e61e/chrome/app/chrome_main.cc
[modify] https://crrev.com/42a29e0ca43402988b63335e0d53a04f1fe2e61e/headless/BUILD.gn
[modify] https://crrev.com/42a29e0ca43402988b63335e0d53a04f1fe2e61e/headless/lib/browser/headless_content_browser_client.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8f3abee06225b664de730b8cd2f7e61897f80ee

commit b8f3abee06225b664de730b8cd2f7e61897f80ee
Author: dvallet <dvallet@chromium.org>
Date: Mon Mar 13 00:03:36 2017

Add fromSurface optional parameter to devtools Page.CaptureScreenshot

This allows headless screenshots to work more consistently in all platforms by getting screenshots from the surface rather than the view. It also fixes screenshots not working properly in headless Mac, due to screen dependency.
BUG= 687407 

Review-Url: https://codereview.chromium.org/2732923002
Cr-Commit-Position: refs/heads/master@{#456309}

[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/headless/app/headless_shell.cc
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/b8f3abee06225b664de730b8cd2f7e61897f80ee/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ade9c19a237e55b6038287ee2ee17fef5529d191

commit ade9c19a237e55b6038287ee2ee17fef5529d191
Author: dvallet <dvallet@chromium.org>
Date: Fri Mar 17 23:55:13 2017

Fix resources path for Mac non component build

BUG= 687407 

Review-Url: https://codereview.chromium.org/2753033004
Cr-Commit-Position: refs/heads/master@{#457905}

[modify] https://crrev.com/ade9c19a237e55b6038287ee2ee17fef5529d191/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a

commit 69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a
Author: dvallet <dvallet@chromium.org>
Date: Mon Apr 03 02:33:55 2017

Enable Mac headless tests now that headless targets are included on Mac build.

BUG= 687407 

Review-Url: https://codereview.chromium.org/2783053002
Cr-Commit-Position: refs/heads/master@{#461362}

[modify] https://crrev.com/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a/testing/buildbot/chromium.mac.json
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1442dca9acb9b78f2c2b047ec77f01e60f266796

commit 1442dca9acb9b78f2c2b047ec77f01e60f266796
Author: timloh <timloh@chromium.org>
Date: Mon Apr 03 04:30:25 2017

Revert of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #2 id:20001 of https://codereview.chromium.org/2783053002/ )

Reason for revert:
These tests are failing on Mac10.10 Tests

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests

Original issue's description:
> Enable Mac headless tests now that headless targets are included on Mac build.
>
> BUG= 687407 
>
> Review-Url: https://codereview.chromium.org/2783053002
> Cr-Commit-Position: refs/heads/master@{#461362}
> Committed: https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a

TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687407 

Review-Url: https://codereview.chromium.org/2792893002
Cr-Commit-Position: refs/heads/master@{#461370}

[modify] https://crrev.com/1442dca9acb9b78f2c2b047ec77f01e60f266796/testing/buildbot/chromium.mac.json
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bdce74f0626abfbd7ac81fdd70c622966b2cd0a

commit 7bdce74f0626abfbd7ac81fdd70c622966b2cd0a
Author: dvallet <dvallet@chromium.org>
Date: Mon Apr 03 10:15:31 2017

Add check for fallback on resources folder, in case that it was already found (e.g. in browsertests builds)

BUG= 687407 

Review-Url: https://codereview.chromium.org/2792913002
Cr-Commit-Position: refs/heads/master@{#461399}

[modify] https://crrev.com/7bdce74f0626abfbd7ac81fdd70c622966b2cd0a/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3447e1d1191f2462d31ea619becd4d32a625cee0

commit 3447e1d1191f2462d31ea619becd4d32a625cee0
Author: dvallet <dvallet@chromium.org>
Date: Mon Apr 03 23:54:52 2017

Reland of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #1 id:1 of https://codereview.chromium.org/2792893002/ )

Reason for revert:
Rollforward: Enable Mac headless tests now that headless targets are included on Mac build

The issue has been fixed in: https://codereview.chromium.org/2792913002/

Original issue's description:
> Revert of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #2 id:20001 of https://codereview.chromium.org/2783053002/ )
>
> Reason for revert:
> These tests are failing on Mac10.10 Tests
>
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests
>
> Original issue's description:
> > Enable Mac headless tests now that headless targets are included on Mac build.
> >
> > BUG= 687407 
> >
> > Review-Url: https://codereview.chromium.org/2783053002
> > Cr-Commit-Position: refs/heads/master@{#461362}
> > Committed: https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a
>
> TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 687407 
>
> Review-Url: https://codereview.chromium.org/2792893002
> Cr-Commit-Position: refs/heads/master@{#461370}
> Committed: https://chromium.googlesource.com/chromium/src/+/1442dca9acb9b78f2c2b047ec77f01e60f266796

TBR=dpranke@chromium.org,skyostil@chromium.org,timloh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687407 

Review-Url: https://codereview.chromium.org/2796753002
Cr-Commit-Position: refs/heads/master@{#461581}

[modify] https://crrev.com/3447e1d1191f2462d31ea619becd4d32a625cee0/testing/buildbot/chromium.mac.json

Comment 16 by dvallet@chromium.org, Apr 13 2017

Blockedon: 709836
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

commit ecb2ad24952b077e71e56ba9d3edfc83c522f32a
Author: dvallet <dvallet@chromium.org>
Date: Thu Apr 13 03:57:26 2017

Enable crashpad for Mac.

This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.

BUG= 687407 

Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}

[modify] https://crrev.com/ecb2ad24952b077e71e56ba9d3edfc83c522f32a/headless/BUILD.gn
[modify] https://crrev.com/ecb2ad24952b077e71e56ba9d3edfc83c522f32a/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/ecb2ad24952b077e71e56ba9d3edfc83c522f32a/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9

commit 84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9
Author: dvallet <dvallet@chromium.org>
Date: Thu Apr 13 05:22:35 2017

Revert of Enable crashpad for Mac (patchset #4 id:60001 of https://codereview.chromium.org/2816593006/ )

Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests

Original issue's description:
> Enable crashpad for Mac.
>
> This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
>
> For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
>
> BUG= 687407 
>
> Review-Url: https://codereview.chromium.org/2816593006
> Cr-Commit-Position: refs/heads/master@{#464289}
> Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

TBR=skyostil@chromium.org,jzfeng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687407 

Review-Url: https://codereview.chromium.org/2819503002
Cr-Commit-Position: refs/heads/master@{#464308}

[modify] https://crrev.com/84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9/headless/BUILD.gn
[modify] https://crrev.com/84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/84d7dbe51cfa93499956ef7551eef7dd1a1a9ec9/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df51c3e48120bc5f68e0fc2cdc92d91592249e98

commit df51c3e48120bc5f68e0fc2cdc92d91592249e98
Author: dvallet <dvallet@chromium.org>
Date: Thu Apr 20 02:26:53 2017

Reland Enable crashpad for Mac.
-- Add :mac_helpers dependendency to headless_lib

Original reason for revert: Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16541%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0

This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.

BUG= 687407 

Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001)

Review-Url: https://codereview.chromium.org/2820453003
Cr-Commit-Position: refs/heads/master@{#465869}

[modify] https://crrev.com/df51c3e48120bc5f68e0fc2cdc92d91592249e98/headless/BUILD.gn
[modify] https://crrev.com/df51c3e48120bc5f68e0fc2cdc92d91592249e98/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/df51c3e48120bc5f68e0fc2cdc92d91592249e98/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a619651df1aa66a84743d770b1736e5f696d95

commit 70a619651df1aa66a84743d770b1736e5f696d95
Author: aboxhall <aboxhall@chromium.org>
Date: Thu Apr 20 04:05:03 2017

Revert of Reland Enable crashpad for Mac. (patchset #1 id:1 of https://codereview.chromium.org/2820453003/ )

Reason for revert:
Sorry, looks like this is still causing some test failures:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16868%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/16868

Original issue's description:
> Reland Enable crashpad for Mac.
> -- Add :mac_helpers dependendency to headless_lib
>
>
>
> Original reason for revert: Reason for revert:
> mac_chromium10.10_rel_ng buildbot failing in browsertests
> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16541%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0
>
>
> This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
>
> For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
>
> BUG= 687407 
>
> Review-Url: https://codereview.chromium.org/2816593006
> Cr-Commit-Position: refs/heads/master@{#464289}
> Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a
>
> patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001)
>
> Review-Url: https://codereview.chromium.org/2820453003
> Cr-Commit-Position: refs/heads/master@{#465869}
> Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92d91592249e98

TBR=skyostil@chromium.org,dvallet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687407 

Review-Url: https://codereview.chromium.org/2826193003
Cr-Commit-Position: refs/heads/master@{#465895}

[modify] https://crrev.com/70a619651df1aa66a84743d770b1736e5f696d95/headless/BUILD.gn
[modify] https://crrev.com/70a619651df1aa66a84743d770b1736e5f696d95/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/70a619651df1aa66a84743d770b1736e5f696d95/headless/lib/headless_content_main_delegate.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862

commit 375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862
Author: dvallet <dvallet@chromium.org>
Date: Fri Apr 21 06:40:55 2017

Reland Enable crashpad for Mac.
-- Add :mac_helpers dependendency to headless_lib

Original reason for revert: Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16541%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0

This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.

BUG= 687407 

Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001)

Review-Url: https://codereview.chromium.org/2820453003
Cr-Original-Commit-Position: refs/heads/master@{#465869}
Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92d91592249e98
Review-Url: https://codereview.chromium.org/2820453003
Cr-Commit-Position: refs/heads/master@{#466275}

[modify] https://crrev.com/375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862/headless/BUILD.gn
[modify] https://crrev.com/375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862/headless/lib/headless_content_main_delegate.cc

Comment 22 by skyos...@chromium.org, May 15 2017

Components: Internals>Headless
Project Member

Comment 23 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c53ef4b54e0d30bc381eb9b0cf531ae78dc6525

commit 6c53ef4b54e0d30bc381eb9b0cf531ae78dc6525
Author: dvallet <dvallet@chromium.org>
Date: Thu May 25 05:40:56 2017

Fix missing library for crasphad_handler in Mac component build

BUG= 687407 

Review-Url: https://codereview.chromium.org/2898203003
Cr-Commit-Position: refs/heads/master@{#474568}

[modify] https://crrev.com/6c53ef4b54e0d30bc381eb9b0cf531ae78dc6525/headless/BUILD.gn

Comment 24 by dvallet@chromium.org, Sep 1 2017

Status: Fixed (was: Assigned)
Headless on Mac has been supported for a while and is in a good enough state to mark this as Done. 

I've done a small write up explaning the underlying changes to enable headless on Mac: https://goo.gl/48egqW
►

Sign in to add a comment