Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment
dhcp config failure caused lab downtime
Project Member Reported by akes...@chromium.org, Feb 1 2017 Back to list
+haowei to fill in details
 
Comment 1 by haoweiw@google.com, Feb 1 2017
DHCP configuration file was modified with in-proper entry from this CL: https://chrome-internal-review.googlesource.com/#/c/322645/

This issue could cause DUTs failed on reboot with no IP assigned to them.

Issue had been resolved by reverting CL. 

A sanity check process of dhcp configuration file need to be followed in order to prevent this in the future.

~/chromeos-admin$ python utils/presubmit_hooks/validate_dhcpd_conf.py
dhcpd.conf is verified successfully for chromeos-ddns1.mtv.corp.google.com-failover.conf.
dhcpd.conf is verified successfully for chromeos-ddns2.cbf.corp.google.com-failover.conf.



  
do we already have that validation script? if so, it's easy enough to add it to presubmit
pre-upload i mean
Comment 4 by haoweiw@google.com, Feb 1 2017
yes, the script already there. 

chromiumos/chromeos-admin/utils/presubmit_hooks/validate_dhcpd_conf.py
Comment 5 Deleted
It seems to require sudo priviledges, which would be painful if we included in the automated preupload script. Can it be modified to not require sudo?
change is reverted but do those hosts which had no IP assigned come back? 
I am yet to see newer build results but older builds from around 2 hours ago seem to have lots of ssh connection failures.

Comment 8 by haoweiw@google.com, Feb 1 2017
Ummm....dhcpd need to run under root privilege and inside of /etc/dhcp/


Comment 9 by aut...@google.com, Feb 9 2017
Cc: ayatane@chromium.org
Labels: -current-issue
Owner: ayatane@chromium.org
+ allen - can this be part of your puppet changes?
Sounds like this could be solved by the next evolution of Puppet tests: after running Puppet in a test VM, which could confirm, e.g., dhcpd started correctly.

Otherwise, there's no trivial way to verify config file syntax beside the current solution of starting dhcpd to check or rolling our own config parser for dhcpd (latter is a bad idea, I oppose it).

Next stage Puppet tests would definitely be nice, but not a short-term task.
Labels: Type-Feature
Labels: -Pri-2 Pri-3
Status: Assigned
Sign in to add a comment