New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687399 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression
Hotlist-MemoryInfra

Blocking:
issue 609475



Sign in to add a comment

Discardable memory logging broken in memory-infra

Project Member Reported by ericrk@chromium.org, Feb 1 2017

Issue description

It seems like discardable memory logging is broken in memory-infra (nothing is logged from renderer processes). I've bisected this to:

https://codereview.chromium.org/2485623002

Still investigating the exact cause.
 
Cc: ssid@chromium.org
I filed  Issue 679755  about this not too long ago about that.
I never realized that it has been duped against Issue 661257.
I didn't manage to look at the bug content bug but the relationship between the two is not clear to me.
That bug points to https://codereview.chromium.org/2459733002/diff/240001/components/discardable_memory/service/discardable_shared_memory_manager.cc#newcode48

I need to read all that bug and both the CLs, I'll do as soon as I have some spare moment. But maybe +ssid has a clearer view of the overall situation.
In the meantime thanks a lot for the bisect!
Blocking: 609475
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efed310cc305f0d89f9d1aa49fb5e0d4ec9ff2cd

commit efed310cc305f0d89f9d1aa49fb5e0d4ec9ff2cd
Author: ssid <ssid@chromium.org>
Date: Tue Feb 07 05:29:58 2017

[memory-infra] Make client discardable segments non-weak

The discardable segments shared between the processes do not add the
same global dump ids since the process id of the client is not available
in the manager. Temporarily we do not create weak dumps since the dump
provider is broken.

BUG=661257,  687399 

Review-Url: https://codereview.chromium.org/2668193002
Cr-Commit-Position: refs/heads/master@{#448554}

[modify] https://crrev.com/efed310cc305f0d89f9d1aa49fb5e0d4ec9ff2cd/components/discardable_memory/common/discardable_shared_memory_heap.cc

Comment 4 by ssid@chromium.org, Feb 10 2017

So this must not be blocking the other bug now since we should have the discardable provider report details on renderer after the CL.
Though the issue is not fully fixed. The issue 661257 tracks the rest of the missing bits. So closing this issue.

Comment 5 by ssid@chromium.org, Feb 10 2017

Status: Fixed (was: Available)

Sign in to add a comment