Form-Not-Secure warning is missing padding around "Learn more" sublabel |
||||||
Issue descriptionChrome Version: 58.0.2998.3 OS: Android What steps will reproduce the problem? (1) Enable #http-form-warning in chrome://flags (2) Visit http://www.ericlawrence.com/regs/login.asp (3) Begin typing in the password. What is the expected result? The "Login not secure" label matches the specs at go/fns-ui-spec -- in particular 10px margin around the "Learn more" sublabel. What happens instead? See screenshot from a Nexus 6 device
,
Feb 1 2017
This probably regressed in M-57 too.
,
Feb 1 2017
Re comment 2: can you explain more? The "Login not secure" warning is new and I think it was laying out correctly as of https://codereview.chromium.org/2627153007 (57.0.2987.0).
,
Feb 1 2017
I meant that I merged https://codereview.chromium.org/2649623002/ into M-57 as https://codereview.chromium.org/2665433002/. So if https://codereview.chromium.org/2649623002/is the culprit, it has unfortunately been merged into M-57 also. Looking at this right now.
,
Feb 3 2017
https://codereview.chromium.org/2664083007/ for merging into M-58 https://codereview.chromium.org/2669383002/ for merging into M-57.
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c30e599ae66e6b96a515ab4537aeeb01ff948456 commit c30e599ae66e6b96a515ab4537aeeb01ff948456 Author: csashi <csashi@google.com> Date: Fri Feb 03 03:56:15 2017 Use the layout specified in dropdown_item.xml when label and sublabel are on the same line. BUG= 687395 Review-Url: https://codereview.chromium.org/2664083007 Cr-Commit-Position: refs/heads/master@{#447916} [modify] https://crrev.com/c30e599ae66e6b96a515ab4537aeeb01ff948456/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
,
Feb 3 2017
,
Feb 3 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/476ab0350f600f46717bb4ebd392cc0b4c442d65 commit 476ab0350f600f46717bb4ebd392cc0b4c442d65 Author: csashi <csashi@google.com> Date: Fri Feb 03 17:33:37 2017 [Merge M57] Sets label's layout params to sublabel only when label and sublabel are not on the same line. NOTRY=true NOPRESUBMIT=true BUG= 687395 Review-Url: https://codereview.chromium.org/2669383002 Cr-Commit-Position: refs/branch-heads/2987@{#289} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/476ab0350f600f46717bb4ebd392cc0b4c442d65/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
,
Feb 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by est...@chromium.org
, Feb 1 2017