Just took a quick look and didn't find any reason why webkit_tests was run on linux_chromium_rel_ng.

"webkit_tests (with patch)" was not run on {mac,win}_chromium_rel_ng, so there's something special about linux_chromium_rel_ng.

Dirk or Pawel, any thoughts about what might have caused this?

I looked and didn't see a reason, either, so it's definitely a bit strange.

Paweł, can you take a look and see if you can find something?

See "git diff to analyze patch" :

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/381397/steps/git%20diff%20to%20analyze%20patch/logs/files :

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/381474/steps/git%20diff%20to%20analyze%20patch/logs/files :

content/browser/plugin_content_origin_whitelist.cc
content/browser/plugin_content_origin_whitelist.h
third_party/WebKit/Source/build/scripts/make_css_property_apis.py
third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h

To see why, inspect bot_update:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/381397/steps/bot_update/logs/stdio :

===Running apply_issue --root_dir src --issue 2667753005 --server https://codereview.chromium.org --force --ignore_deps --no-auth --patchset 1 --whitelist DEPS (attempt #1)===
In directory: /b/c/b/linux
Connecting to https://codereview.chromium.org
Downloading patch from https://codereview.chromium.org/2667753005/#ps1

Applying the patch from https://codereview.chromium.org/2667753005/#ps1
Found extra files: ['third_party/WebKit/Source/build/scripts/make_css_property_apis.py', 'third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h', 'third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h']
===Succeeded in 0.0 mins===

That should IMO be a hard error.

What are extra files?

Uploaded https://chromium-review.googlesource.com/c/435200/ .

depot_tools reports extra files, i.e. files that are not part of the patch but are modified in the checkout.

Do we have any idea how those files got there? I thought bot_update committed the patches when it applied them.

Thanks for the fix!

Bot_update (well, apply patch) puts the files in staging but doesn't commit them.  This is because steps that analyze "what changed" will diff between staging and HEAD to figure out what to run.

I think we're hitting the same issue in bug 692067, so dup'ing this out since there's a bit more detail there.