New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687391 link

Starred by 1 user
Status: Verified
Owner:
█ dsansome@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Generated code no longer can be inspected in code search

Project Member Reported by lukasza@chromium.org, Jan 31 2017 
This used to work and used to rely on this quite often :-(

Example flow / repro that is broken now:
1. Go to line 77 in Settings.h : https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Settings.h?q=Settings.h&dr=CSs&l=77

2. Click on SETTINGS_GETTERS_AND_SETTERS to be taken to the location of macro definition

3. Arrive at https://cs.chromium.org/chromium/src/out/Debug/gen/blink/core/SettingsMacros.h?dr=CSs&l=8

EXPECTED BEHAVIOR:
- SettingsMacros.h can be read in code search
- xrefs to/from SettingsMacros.h work
- Searching for SettingsMacros.h finds the file

ACTUAL BEHAVIOR:
- SettingsMacros.h shows Can't load 'chromium/src/out/Debug/gen/blink/core/SettingsMacros.h': Could not resolve path src/out/Debug/gen/blink/core/SettingsMacros.h.
- Searching for SettingsMacros.h cannot find the file.

Comment 1 by dsansome@chromium.org, Feb 1 2017

Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
Ugh.  The thing that copies generated files out of the build machine uses rsync --exclude-cvs, which says excludes the following files:

RCS SCCS CVS CVS.adm RCSLOG cvslog.* tags TAGS .make.state .nse_depinfo *~ #* .#* ,* _$* *$ *.old *.bak *.BAK
*.orig *.rej .del-* *.a *.olb *.o *.obj *.so *.exe *.Z *.elc *.ln core .svn/ .git/ .hg/ .bzr/

Notice the "core" in there.  So it's excluding the whole gen/blink/core directory.
I'll fix it now...

Comment 2 by emso@chromium.org, Feb 1 2017

Status: Verified (was: Started)
This issue seems to be resolved now. Please re-open if it reappears.

Comment 3 by dsansome@chromium.org, Feb 1 2017 

This was fixed by https://chromium-review.googlesource.com/c/435181/ but bugdroid didn't comment here for some reason :(

Comment 4 by dsansome@chromium.org, Feb 1 2017 

Issue 687515 for bugdroid, sigh.
►

Sign in to add a comment