v1app window bounds restore logic should behave like v2app |
|||||||||
Issue descriptionChrome Version : 56.0.2924.79 OS Version: 9000.76.0 This regressed from a week ago. 1) Right click on GMail app 2) Select "Open as Window" 3) Open app 4) Dock app to left (via window control or by dragging it) 5) Close app 6) Open app Expected App opens in position when it was closed Actual App opens in different position
,
Jan 31 2017
,
Jan 31 2017
Actually, this also happens to any restored window. They always come back glued to the right side of the window.
,
Feb 1 2017
Let me do bisect first since this is a recent regression. I also find a maybe related but long time ago issue: issue 353135.
,
Feb 1 2017
This is not a recent regression. It also breaks on M-55 stable. Actually it should be a dup of issue 353135. Since it already exists for a long time (maybe never work right?), I would suggest remove RBS for m-56. If restoring to snapped state is what we want, I am happy to take a look in M-58.
,
Feb 1 2017
,
Feb 1 2017
lower the priority since it has been a long term issue.
,
Feb 1 2017
No, that's different issue. Let's discuss offline.
,
Feb 1 2017
That's being said, I'm not 100% sure what was the original behavior. Session restore does restore the bounds (but not state, which is WAI and similar to 353135)
,
Feb 2 2017
For record, it is also broken on M53.
,
Feb 2 2017
Let's chat offline because it's hard to tell what's regressed or not.
,
Feb 11 2017
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc42ea7b1264dc128a1e454d92eebc25e1076c5 commit 2fc42ea7b1264dc128a1e454d92eebc25e1076c5 Author: warx <warx@chromium.org> Date: Tue Feb 14 03:08:58 2017 cros: Disable the auto management logic for v1app browser window Changes: (1) For "open as window" browser window (v1app window), we disable auto management logic. So that they can restore the saved window bounds, not interrupted by auto placement such as centering window in work area. (2) Simplify BrowserRemembersDockedState to test only state not bounds for reasons (a) bounds logic for app or tabbed browser window is tested in added test coverage, (b) this test will soon be removed in M-58 because of deprecation of docked window on Chrome OS. BUG= 687385 TEST=emulator tests show that v1app bounds restoring works just like v2 apps; also test coverage is added. Review-Url: https://codereview.chromium.org/2690563005 Cr-Commit-Position: refs/heads/master@{#450216} [modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_frame_ash.cc [add] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc [modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc [modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc [modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/test/BUILD.gn
,
Feb 14 2017
,
Feb 22 2017
,
Mar 30 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kuscher@chromium.org
, Jan 31 2017