New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687385 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

v1app window bounds restore logic should behave like v2app

Project Member Reported by kuscher@chromium.org, Jan 31 2017

Issue description

Chrome Version       : 56.0.2924.79
OS Version: 9000.76.0

This regressed from a week ago. 

1) Right click on GMail app
2) Select "Open as Window"
3) Open app
4) Dock app to left (via window control or by dragging it)
5) Close app
6) Open app

Expected
App opens in position when it was closed

Actual
App opens in different position
 
Labels: -M-57 M-56
Actuall this regressed from 56 beta to 56 beta
Labels: -Pri-1 ReleaseBlock-Stable Pri-0
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)
Actually, this also happens to any restored window. They always come back glued to the right side of the window.

Comment 4 by warx@chromium.org, Feb 1 2017

Labels: Needs-Bisect
Status: Started (was: Assigned)
Let me do bisect first since this is a recent regression.

I also find a maybe related but long time ago issue: issue 353135.

Comment 5 by warx@chromium.org, Feb 1 2017

Labels: -M-56 -Needs-Bisect -ReleaseBlock-Stable M-58
This is not a recent regression. It also breaks on M-55 stable.

Actually it should be a dup of issue 353135. Since it already exists for a long time (maybe never work right?), I would suggest remove RBS for m-56.

If restoring to snapped state is what we want, I am happy to take a look in M-58.

Comment 6 by warx@chromium.org, Feb 1 2017

Cc: pkotw...@chromium.org
Issue 353135 has been merged into this issue.

Comment 7 by warx@chromium.org, Feb 1 2017

Labels: -Pri-0 Pri-2
lower the priority since it has been a long term issue.
Labels: -Pri-2 Pri-1
No, that's different issue. Let's discuss offline.
That's being said, I'm not 100% sure what was the original behavior.
Session restore does restore the bounds (but not state, which is WAI and similar to 353135)

Comment 10 by warx@chromium.org, Feb 2 2017

For record, it is also broken on M53.
Let's chat offline because it's hard to tell what's regressed or not.

Comment 12 by warx@chromium.org, Feb 11 2017

Summary: v1app window bounds restore logic should behave like v2app (was: Window position is not remembered for windowed windows)
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc42ea7b1264dc128a1e454d92eebc25e1076c5

commit 2fc42ea7b1264dc128a1e454d92eebc25e1076c5
Author: warx <warx@chromium.org>
Date: Tue Feb 14 03:08:58 2017

cros: Disable the auto management logic for v1app browser window

Changes:
(1) For "open as window" browser window (v1app window), we disable auto management logic. So that they can restore the saved window bounds, not interrupted by auto placement such as centering window in work area.
(2) Simplify BrowserRemembersDockedState to test only state not bounds for reasons (a) bounds logic for app or tabbed browser window is tested in added test coverage, (b) this test will soon be removed in M-58 because of deprecation of docked window on Chrome OS.

BUG= 687385 
TEST=emulator tests show that v1app bounds restoring works just like v2 apps; also test coverage is added.

Review-Url: https://codereview.chromium.org/2690563005
Cr-Commit-Position: refs/heads/master@{#450216}

[modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_frame_ash.cc
[add] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
[modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
[modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/2fc42ea7b1264dc128a1e454d92eebc25e1076c5/chrome/test/BUILD.gn

Comment 14 by warx@chromium.org, Feb 14 2017

Status: Fixed (was: Started)

Comment 15 by derat@google.com, Feb 22 2017

Cc: warx@chromium.org sky@chromium.org
 Issue 693567  has been merged into this issue.
Status: Verified (was: Fixed)

Sign in to add a comment