New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687375 link

Starred by 3 users
Status: Duplicate
Merged: issue 808720
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Aug 2
Cc:
mfo...@chromium.org
█ imch...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 687356


Sign in to add a comment

[DIAL] Implement DIAL MediaSinkService

Project Member Reported by imch...@chromium.org, Jan 31 2017 
Implement MediaSinkService for DIAL which can be used by MediaRouter directly.

Discovery:
- Refactor DialService / DialRegistry and friends so that it can be used by MediaSinkService, if needed.
Resolution:
- Refactor DeviceDescriptionFetcher, if needed.
Sink query:
- Implement DIAL sink query

Others:
- Port optimizations (e.g., caching, retries) in the extension implementation.

Comment 1 by imch...@chromium.org, Jan 31 2017

Blockedon: 687356

Comment 2 by imch...@chromium.org, Jan 31 2017

Blocking: 687383

Comment 3 by sko...@chromium.org, Feb 9 2017

Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b26f93c8009b26acc32161860c6dd1aac3d9818

commit 1b26f93c8009b26acc32161860c6dd1aac3d9818
Author: zhaobin <zhaobin@chromium.org>
Date: Tue Mar 07 20:16:23 2017

[Dial] Refactor DialRegistry and DeviceDescriptionFetcher so they can be used by MediaSinkService

- Make DialRegistry listen to multiple observers (DialAPI and MediaSinkService)
- Make DeviceDescriptionFetcher run on both UI (for extension functions) and IO (for MediaSinkService) threads

BUG= 687375 

Review-Url: https://codereview.chromium.org/2702503003
Cr-Commit-Position: refs/heads/master@{#455192}

[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/device_description_fetcher.cc
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/device_description_fetcher.h
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/device_description_fetcher_unittest.cc
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/dial_api.cc
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/dial_registry.cc
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/dial_registry.h
[modify] https://crrev.com/1b26f93c8009b26acc32161860c6dd1aac3d9818/chrome/browser/extensions/api/dial/dial_registry_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687cddcf3340fb4e163ec55462dd2a66b9167774

commit 687cddcf3340fb4e163ec55462dd2a66b9167774
Author: zhaobin <zhaobin@chromium.org>
Date: Mon Mar 27 22:16:11 2017

[Media Router] Parse device description xml in utility process

- Add dial_device_description_parser.mojom to support communication between browser and utility process
- Add DialDeviceDescriptionParser in chrome/utility to handle xml parsing and scrubbing
- Add SafeDialDeviceDescriptionParser in chrome/browser to start parsing in utility process

BUG= 687375 

Review-Url: https://codereview.chromium.org/2745653008
Cr-Commit-Position: refs/heads/master@{#459902}

[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/app/generated_resources.grd
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/browser/media/router/discovery/BUILD.gn
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/common/BUILD.gn
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/common/media_router/BUILD.gn
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/common/media_router/OWNERS
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/common/media_router/dial_device_description_parser.mojom
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/test/BUILD.gn
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/BUILD.gn
[modify] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/chrome_content_utility_client.cc
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/media_router/OWNERS
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/media_router/dial_device_description_parser_impl.cc
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/media_router/dial_device_description_parser_impl.h
[add] https://crrev.com/687cddcf3340fb4e163ec55462dd2a66b9167774/chrome/utility/media_router/dial_device_description_parser_impl_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa

commit c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa
Author: imcheng <imcheng@chromium.org>
Date: Tue Apr 04 18:38:25 2017

[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also remove duplicate strong_binding.h #include.

BUG=705968, 687375 

Review-Url: https://codereview.chromium.org/2784923002
Cr-Commit-Position: refs/heads/master@{#461782}

[modify] https://crrev.com/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa/chrome/test/BUILD.gn
[modify] https://crrev.com/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa/chrome/utility/BUILD.gn
[modify] https://crrev.com/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa/chrome/utility/chrome_content_utility_client.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18ec3f9860a0b3069fc6f32a28fd48b158e1f409

commit 18ec3f9860a0b3069fc6f32a28fd48b158e1f409
Author: zhaobin <zhaobin@chromium.org>
Date: Fri Apr 28 06:23:07 2017

[Media Router] Add README.md for DIAL discovery

BUG= 687375 

Review-Url: https://codereview.chromium.org/2844103002
Cr-Commit-Position: refs/heads/master@{#467918}

[add] https://crrev.com/18ec3f9860a0b3069fc6f32a28fd48b158e1f409/chrome/browser/media/router/discovery/dial/README.md
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c

commit a26ad25c4fd2cb7bbe286745d43e507dc658ba2c
Author: zhaobin <zhaobin@chromium.org>
Date: Sun Apr 30 03:29:47 2017

[Media Router] Add DialMediaSinkService and DeviceDescriptionService

Discover process:
  DialMediaSinkService.Start() registers itself with DialRegistry
  DialMediaSinkService.OnDialDeviceEvent() gets invoked when device data comes back, and starts a 3s timer
  Start description fetches for each device
  DeviceDescriptionService.OnDeviceDescriptionFetchComplete() gets invoked when device description comes back.
  Starts an XML parser in utility process to parse device description XML
  DialMediaSinkService.OnDeviceDescriptionAvailable() gets invoked when parsing in utility process finishes
  Create MediaSinkInternal and store it in DialMediaSinkService's sink map
  Invoke DialMediaSinkService.FetchCompleted() when timer expires

Design doc:

https://docs.google.com/document/d/1lJbE4Oc9q1amkWEaD2ZL4mHEdRRlKHvwxUUcJmNC8b8/edit#heading=h.ur85je1upm9u

BUG= 687375 

Review-Url: https://codereview.chromium.org/2701633002
Cr-Commit-Position: refs/heads/master@{#468251}

[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/BUILD.gn
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/device_description_fetcher.h
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/device_description_service.cc
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/device_description_service.h
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_device_data.cc
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_media_sink_service.cc
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_media_sink_service.h
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_media_sink_service_unittest.cc
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/dial_registry.h
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/parsed_dial_device_description.cc
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/parsed_dial_device_description.h
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
[delete] https://crrev.com/9fb7f6bfb5a838b8e231134e5b3f3dda67c5f556/chrome/browser/media/router/media_sink_service.h
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/BUILD.gn
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/discovery/media_sink_internal.cc
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/discovery/media_sink_internal_unittest.cc
[rename] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/discovery/media_sink_service.cc
[add] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/common/media_router/discovery/media_sink_service.h
[modify] https://crrev.com/a26ad25c4fd2cb7bbe286745d43e507dc658ba2c/chrome/test/BUILD.gn
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f161a688a7af9b17a63fea84cb0312c5c297903

commit 7f161a688a7af9b17a63fea84cb0312c5c297903
Author: zhaobin <zhaobin@chromium.org>
Date: Fri May 12 18:07:51 2017

[Media Router] Add features to control browser side discovery

Split from https://codereview.chromium.org/2837363002/

- Add kEnableDialLocalDiscovery and kEnableCastDiscovery feature to turn on/off browser side DIAL and Cast discovery
- Pass those features to MRP
- Update unit tests

cl/154204127 (landed) handles enable_dial_discovery and enable_dial_discovery flag in extension side.

BUG= 687375 

Review-Url: https://codereview.chromium.org/2873893003
Cr-Commit-Position: refs/heads/master@{#471367}

[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/media_router_feature.h
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/7f161a688a7af9b17a63fea84cb0312c5c297903/chrome/renderer/resources/extensions/media_router_bindings.js
Project Member

Comment 12 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0202e59885b64b46b56aa8d342a04fe3d3aeac8a

commit 0202e59885b64b46b56aa8d342a04fe3d3aeac8a
Author: zhaobin <zhaobin@chromium.org>
Date: Wed May 17 20:53:25 2017

[Media Router] Create MediaSinkServiceBase and make DialMediaSinkService inherit from it

Extract some common functions from DialMediaSinkService to MediaSinkServiceBase so that CastMediaSinkService can use them.

BUG= 687375 

Review-Url: https://codereview.chromium.org/2878103004
Cr-Commit-Position: refs/heads/master@{#472558}

[modify] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/BUILD.gn
[delete] https://crrev.com/aa72d98b41a08607308b1f1ccb9604fff36aa432/chrome/browser/media/router/discovery/dial/dial_media_sink_service.h
[rename] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc
[add] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h
[add] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
[delete] https://crrev.com/aa72d98b41a08607308b1f1ccb9604fff36aa432/chrome/browser/media/router/discovery/dial/dial_media_sink_service_unittest.cc
[add] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/media_sink_service_base.cc
[add] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/media_sink_service_base.h
[add] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/browser/media/router/discovery/media_sink_service_base_unittest.cc
[modify] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/common/media_router/discovery/media_sink_service.h
[modify] https://crrev.com/0202e59885b64b46b56aa8d342a04fe3d3aeac8a/chrome/test/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, May 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2

commit ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2
Author: zhaobin <zhaobin@chromium.org>
Date: Sat May 27 03:12:45 2017

[Media Router] Use DialMediaSinkServiceDelegate in MediaRouterMojoImpl

- Added DialMediaSinkServiceDelegate to handle thread hopping between IO/UI thread
- Added MediaRouterMojoImpl::StartDiscovery()

TODO:
- Call StartDiscovery() in MediaRouterMojoImpl::RegisterMediaRouteProvider()

BUG= 687375 

Review-Url: https://codereview.chromium.org/2837363002
Cr-Commit-Position: refs/heads/master@{#475230}

[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/BUILD.gn
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
[add] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.cc
[add] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.h
[add] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/discovery/media_sink_service_base.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/media_router_factory.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/common/media_router/discovery/media_sink_service.h
[modify] https://crrev.com/ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2/chrome/test/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfa975069fd5856fdc4c494276a3a9af6be3da79

commit cfa975069fd5856fdc4c494276a3a9af6be3da79
Author: zhaobin <zhaobin@chromium.org>
Date: Thu Jun 08 03:59:40 2017

[MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl

For browser side DIAL discovery, record device count at browser side. Keep in sync with recordDeviceCounts_() function in dial_sink_discovery_service.js (https://cs.corp.google.com/piper///depot/google3/chrome_platform/media_router/extension/providers/dial/dial_sink_discovery_service.js?rcl=157541007&l=209)

BUG= 687375 

Review-Url: https://codereview.chromium.org/2916163002
Cr-Commit-Position: refs/heads/master@{#477877}

[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/discovery/media_sink_service_base.h
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/cfa975069fd5856fdc4c494276a3a9af6be3da79/tools/metrics/histograms/histograms.xml

Comment 15 by mfo...@chromium.org, Oct 26 2017

Blocking: -687383

Comment 16 by mfo...@chromium.org, Oct 26 2017

Blocking: 752604

Comment 17 by mfo...@chromium.org, Oct 26 2017

Cc: -zhaobin@chromium.org
Components: -Blink>PresentationAPI Internals>Cast>API
Owner: zhaobin@chromium.org
Status: Assigned (was: Available)
Can this be closed?

Comment 18 by imch...@chromium.org, Oct 26 2017 

We have implemented enough support to unblock in-browser Cast discovery. We can keep this open to track implementing DIAL sink queries.

Comment 19 by imch...@chromium.org, Oct 26 2017

Blocking: -752604

Comment 20 by mfo...@chromium.org, Aug 2

Owner: imch...@chromium.org

Comment 21 by imch...@chromium.org, Aug 2

Mergedinto: 808720
Status: Duplicate (was: Assigned)
►

Sign in to add a comment