WebVR presentation from iframe fails. |
||||
Issue descriptionSimple html page with "<iframe src="https://webvr.info/samples/03-vr-presentation.html" ></iframe>" will 'successfully' enter presentation but get kicked out by the fullscreen check in VrDisplay. The rendering while briefly in presentation is also incorrect due to failing to fullscreen the canvas.
,
Jan 31 2017
,
Feb 1 2017
Ah, this is because you need to put allowFullScreen="true" on the iframe or fullscreen requests are rejected. Still seems like a bug that needs fixing though. In M58 we should look into gating webVR behind <iframe enable="vr">, but for now disabling it when we can't go fullscreen seems reasonable.
,
Feb 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8 commit b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8 Author: mthiesse <mthiesse@chromium.org> Date: Wed Feb 01 17:01:44 2017 Reject requestPresent requests when fullscreen is not enabled. BUG= 687369 Review-Url: https://codereview.chromium.org/2662213006 Cr-Commit-Position: refs/heads/master@{#447540} [modify] https://crrev.com/b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp [modify] https://crrev.com/b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/b29ec7143c6fbc8ea4271c7f5e3428dae0c4eba8/third_party/WebKit/Source/modules/vr/VRDisplay.h
,
Feb 1 2017
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mthiesse@chromium.org
, Jan 31 2017