jiameng@ - this has regressed in r446952.  Can you please revert?  Because of this regression we don't have any coverage for OOPIF support at ToT (we are shipping --isolate-extensions in M56 to stable, so continued test coverage of OOPIF support is really important to us).

First red build: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/13675

This blocks some CQ jobs, because the linux_site_isolation trybot is required by for some CLs.  Let me try to revert r446952.

Hello,

I tried to reproduce the error, but haven't been able to do so. 

From a clean client (without any of my modifications), here's what I have

$ cat out/Default/args.gn 
use_goma = true
is_debug = false
is_component_build = true
dcheck_always_on = true
symbol_level = 1

$ ninja -C out/Default -j2000 blink_tests
$ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default -v --additional-drt-flag=--site-per-process --no-retry-failures --iterations=5 http/tests/security/secureContexts

Using port 'linux-trusty'
Test configuration: <trusty, x86_64, release>
View the test results at file:///usr/local/google/home/jiameng/chromium/src/out/Default/layout-test-results/results.html
View the archived results dashboard at file:///usr/local/google/home/jiameng/chromium/src/out/Default/layout-test-results/dashboard.html
Using random order with seed: 1486015017
Baseline search path: linux -> win -> site-per-process -> linux -> win -> generic
Using Release build
Pixel tests enabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /usr/local/google/home/jiameng/chromium/src/out/Default/content_shell --site-per-process --run-layout-test --enable-crash-reporter --crash-dumps-dir=/usr/local/google/home/jiameng/chromium/src/out/Default/crash-dumps -

Found 10 tests; running 10 (5 times each: --repeat-each=1 --iterations=5), skipping 0.
                  
System dependencies check failed.
To override, invoke with --nocheck-sys-deps

[12140:12140:0202/165658.412776:5607132959:ERROR:browser_main_loop.cc(1664)] Unable to open X display.
[12140:12140:0202/165658.412978:5607133108:FATAL:layout_test_browser_main.cc(130)] Check failed: exit_code < 0 (1 vs. 0)BrowserMainRunner::Initialize failed in LayoutTestBrowserMain
#0 0x7f0eaa1eaca7 base::debug::StackTrace::StackTrace()
#1 0x7f0eaa20edcb logging::LogMessage::~LogMessage()
#2 0x0000004ff293 LayoutTestBrowserMain()
#3 0x0000004feeb5 content::ShellMainDelegate::RunProcess()
#4 0x7f0eab518ae9 content::RunNamedProcessTypeMain()
#5 0x7f0eab519566 content::ContentMainRunnerImpl::Run()
#6 0x7f0eab517e90 content::ContentMain()
#7 0x000000466051 main
#8 0x7f0ea3303f45 __libc_start_main
#9 0x000000465f31 <unknown>

So I got an unexpected error from a clean client. Any suggestions?

Thanks,
Jia

I've put in a patch: https://codereview.chromium.org/2594913002/

I'm closing this bug now.
Thanks,
Jia