New issue
Advanced search Search tips

Issue 687352 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Merge the use of web_profiles() and GetProfiles()

Project Member Reported by se...@chromium.org, Jan 31 2017

Issue description

Now that server profiles are not used in Autofill anymore, these two functions serve the same purpose. They should get merged.
 

Comment 1 Deleted

Comment 2 by rogerm@chromium.org, Sep 29 2017

Owner: rogerm@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cac9503423bf3d0cfb467cdc76e6bb3702bb928

commit 5cac9503423bf3d0cfb467cdc76e6bb3702bb928
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Oct 03 16:21:45 2017

[autofill] Clean up PDM GetProfiles+GetCreditCards

Due to legacy/technical-debt, the autofill::PersonalDataManager
was holding a cache of profile and credit card raw pointers in
addition to the owning vectors of std::unique_ptr for each. The
getter functions for these raw pointer vectors was wastefully
clearing the vectors and repopulating them on each get.

This CL cleans up the useless cache variables, fixes the function
signatures, and adds explicit memory reservations to the getters. It
also merges several identical getter functions for retrieving the
profile pointers: GetProfiles(), GetProfiles(bool), web_profiles().

Bug:  687352 
Change-Id: Id614d14832ce926a75e61d2663a0be7805988e33
Reviewed-on: https://chromium-review.googlesource.com/692717
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506062}
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/autofill_merge_unittest.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/5cac9503423bf3d0cfb467cdc76e6bb3702bb928/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm

Comment 4 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Assigned)
Status: Fixed (was: Untriaged)
I think we should be good to mark as fixed? 

Sign in to add a comment