New issue
Advanced search Search tips

Issue 687339 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

The Payment Request dialog should show a Cancel button

Project Member Reported by anthonyvd@chromium.org, Jan 31 2017 
All the sheets in the Payment Request dialog include a "Cancel" button that closes the dialog and calls onError(). For code simplicity, this button should be added to all sheets by default and its click event should be handled by the base sheet controller.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b084b11b0404e4fec76c5ab372ef39226596dc0

commit 1b084b11b0404e4fec76c5ab372ef39226596dc0
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Feb 06 16:14:25 2017

[Web Payments] Add Cancel button to all sheets

This CL refactors a bit of the Controller code to add a Cancel button
to all sheets. The base PaymentRequestSheetController class handles
clicks on the Cancel button (and other buttons that are common to
multiple sheets, like the back arrow).

This CL also adds a function to build the button row of the dialog.
Currently, this function only creates and lays out the Cancel button.

BUG= 687339 

Review-Url: https://codereview.chromium.org/2668063003
Cr-Commit-Position: refs/heads/master@{#448266}

[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/OWNERS
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/order_summary_view_controller.h
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_method_view_controller.h
[add] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/shipping_list_view_controller.cc
[modify] https://crrev.com/1b084b11b0404e4fec76c5ab372ef39226596dc0/chrome/browser/ui/views/payments/shipping_list_view_controller.h

Comment 2 by anthonyvd@chromium.org, Feb 7 2017

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment