Issue metadata
Sign in to add a comment
|
calling CHECK should result in EXCEPTION_BREAKPOINT exit code from process |
||||||||||||||||||||
Issue descriptionChrome Version: Chrome 52+ OS: Windows What steps will reproduce the problem? (1) Call CHECK() from a renderer. (2) Look in chrome://histograms (3) What is the expected result? An entry in CrashExitCodes.Renderer in bucket 2147483645 (STATUS_BREAKPOINT) What happens instead? An entry in CrashExitCodes.Renderer in bucket 1073741819 (STATUS_ACCESS_VIOLATION) Please use labels and text to provide additional information. It seems that https://codereview.chromium.org/1982123002/ changed this behavior, maybe? For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 6 2017
as part of https://codereview.chromium.org/2648423006/ I found a good place to add regression tests for this type of behavior, so once scott's CL lands, I'll go and add a browser test and a magic URL to verify this actually sticks.
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a17c8db528cadca9eef98ce03b0910700735722e commit a17c8db528cadca9eef98ce03b0910700735722e Author: scottmg <scottmg@chromium.org> Date: Wed Feb 15 21:35:49 2017 Make CHECK int 3 on Windows, rather than crash Not being able to distinguish intentional crashes (CHECK) from unintentional ones (other access violations) in terms of exit codes reduces the amount of signal we have in stability metrics. R=wfh@chromium.org BUG= 664209 , 687326 Review-Url: https://codereview.chromium.org/2676483002 Cr-Commit-Position: refs/heads/master@{#450809} [modify] https://crrev.com/a17c8db528cadca9eef98ce03b0910700735722e/base/logging.h [modify] https://crrev.com/a17c8db528cadca9eef98ce03b0910700735722e/base/logging_unittest.cc
,
Feb 15 2017
,
Feb 16 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/225319af95b483fc525e08149b4d1d64524dd9c4 commit 225319af95b483fc525e08149b4d1d64524dd9c4 Author: Scott Graham <scottmg@chromium.org> Date: Thu Feb 16 22:14:16 2017 Make CHECK int 3 on Windows, rather than crash Not being able to distinguish intentional crashes (CHECK) from unintentional ones (other access violations) in terms of exit codes reduces the amount of signal we have in stability metrics. R=wfh@chromium.org BUG= 664209 , 687326 Review-Url: https://codereview.chromium.org/2676483002 Cr-Commit-Position: refs/heads/master@{#450809} (cherry picked from commit a17c8db528cadca9eef98ce03b0910700735722e) Review-Url: https://codereview.chromium.org/2695833008 . Cr-Commit-Position: refs/branch-heads/2987@{#564} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/225319af95b483fc525e08149b4d1d64524dd9c4/base/logging.h [modify] https://crrev.com/225319af95b483fc525e08149b4d1d64524dd9c4/base/logging_unittest.cc
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827 commit c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827 Author: wfh <wfh@chromium.org> Date: Wed Feb 22 21:05:13 2017 Add test for CHECK exit code behavior. BUG= 687326 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2697423002 Cr-Commit-Position: refs/heads/master@{#452197} [modify] https://crrev.com/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827/chrome/browser/metrics/metrics_service_browsertest.cc [modify] https://crrev.com/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827/content/browser/frame_host/debug_urls.cc [modify] https://crrev.com/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827/content/public/common/url_constants.cc [modify] https://crrev.com/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827/content/public/common/url_constants.h [modify] https://crrev.com/c0f16eacc2e54b2a6c0c3a4f6f2766f59d582827/content/renderer/render_frame_impl.cc
,
Mar 3 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Feb 1 2017