Settings should have keys, values and titles. Titles are going to be read either from descriptors or passed into createSetting. That is needed to remove text parameter from UI.ToolbarCheckbox (or at least make it optional).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b874581aab39ed174ed99b4fd2d115bd1e375a2a commit b874581aab39ed174ed99b4fd2d115bd1e375a2a Author: luoe <luoe@chromium.org> Date: Tue Feb 14 02:31:11 2017 DevTools: pass title when creating settings Settings can now be created with an optional 'title', affecting the setting classes and constructors. This lets us create toolbar checkboxes that inherit titles from their setting. BUG= 687315 Review-Url: https://codereview.chromium.org/2678623002 Cr-Commit-Position: refs/heads/master@{#450205} [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/common/Settings.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js [modify] https://crrev.com/b874581aab39ed174ed99b4fd2d115bd1e375a2a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
Comment 1 by pfeldman@chromium.org
, Jan 31 2017