^^^
Animated the editor UI in and out similar to payment request UI to be consistent. Attached is the video record on my nexus 6.
Adding Bruno for his take, but looks good to me.
Can you show how adding a new billing address looks?
It's exactly the same as adding a new shipping address. Find a problem that the animation is a little bit unsmooth on my nexus 5 for card editor view. Profiling render to see what we can do to improve it.
LGTM!
A little bit more smooth solution on nexus 5, video is here: https://drive.google.com/file/d/0B4yF5XJG4VQANVpNQ0RMdVIyTEk/view?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a62cb56b08816606acc1db1f7c73002aad62ba commit 07a62cb56b08816606acc1db1f7c73002aad62ba Author: gogerald <gogerald@chromium.org> Date: Mon Feb 06 21:12:18 2017 Rename mIsShowingEditDialog to mIsExpandedToFullHeight BUG= 687312 Review-Url: https://codereview.chromium.org/2678003004 Cr-Commit-Position: refs/heads/master@{#448388} [modify] https://crrev.com/07a62cb56b08816606acc1db1f7c73002aad62ba/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4c2f7cca38031be613acc6a0afb98b74b980af commit 3e4c2f7cca38031be613acc6a0afb98b74b980af Author: gogerald <gogerald@chromium.org> Date: Mon Feb 06 22:52:35 2017 Animates EditorView in and out This CL also fixed a revealed integration test bug BUG= 687312 Review-Url: https://codereview.chromium.org/2670853002 Cr-Commit-Position: refs/heads/master@{#448424} [modify] https://crrev.com/3e4c2f7cca38031be613acc6a0afb98b74b980af/chrome/android/java/res/layout/payment_request_editor.xml [modify] https://crrev.com/3e4c2f7cca38031be613acc6a0afb98b74b980af/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/3e4c2f7cca38031be613acc6a0afb98b74b980af/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/3e4c2f7cca38031be613acc6a0afb98b74b980af/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java
Comment 1 by gogerald@chromium.org
, Feb 1 201717.0 MB
17.0 MB Download