New issue
Advanced search Search tips

Issue 687307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert BiquadFilter tests to testharness

Project Member Reported by rtoy@chromium.org, Jan 31 2017

Issue description

Convert BiquadFilter tests to use testharness.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2eb07c3ac8d9c52d0514cd8abdcf565c6becf7e

commit f2eb07c3ac8d9c52d0514cd8abdcf565c6becf7e
Author: rtoy <rtoy@chromium.org>
Date: Wed Feb 01 17:33:57 2017

Convert BiquadFilter Audit layout tests to testharness

Test converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

BUG= 687307 
TEST=biquad-automation.html

Review-Url: https://codereview.chromium.org/2666153002
Cr-Commit-Position: refs/heads/master@{#447549}

[delete] https://crrev.com/06fb5480e59a9ad8f10a733c7e45bec4f4c7bec9/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-automation-expected.txt
[modify] https://crrev.com/f2eb07c3ac8d9c52d0514cd8abdcf565c6becf7e/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-automation.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6c30239d7d6a2f2db9c37571df96dd73c9300d6

commit b6c30239d7d6a2f2db9c37571df96dd73c9300d6
Author: rtoy <rtoy@chromium.org>
Date: Thu Feb 02 21:39:29 2017

Convert BiquadFilter response tests to testharness

Convert tests of the filter responses to use testharness and new
Audit.

BUG= 687307 
TEST=biquad-allpass.html, biquad-bandpass.html, biquad-highpass.html,
biquad-highshelf.html, biquad-lowpass.html, biquad-lowshelf.html,
biquad-notch.html, biquad-peaking.html

Review-Url: https://codereview.chromium.org/2667153002
Cr-Commit-Position: refs/heads/master@{#447849}

[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-allpass-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-allpass.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-bandpass-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-bandpass.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highpass-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highpass.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highshelf-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highshelf.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowpass-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowpass.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowshelf-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowshelf.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html
[delete] https://crrev.com/537181f43f30baf668b1fd2a52893b789ada2198/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-peaking-expected.txt
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-peaking.html
[modify] https://crrev.com/b6c30239d7d6a2f2db9c37571df96dd73c9300d6/third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js

Comment 3 by rtoy@chromium.org, Feb 3 2017

Blocking: 623160
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd02bafbf4a71ca89c81dd2d27a1319a4e5911a

commit ebd02bafbf4a71ca89c81dd2d27a1319a4e5911a
Author: rtoy <rtoy@chromium.org>
Date: Mon Feb 06 21:03:32 2017

Convert biquadfilternode-basic test to testharness

Manually convert test to testharness and new Audit.  Update expected
result file since there's an console log message.

BUG= 687307 
TEST=biquadfilternode-basic.html

Review-Url: https://codereview.chromium.org/2670003005
Cr-Commit-Position: refs/heads/master@{#448385}

[modify] https://crrev.com/ebd02bafbf4a71ca89c81dd2d27a1319a4e5911a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic-expected.txt
[modify] https://crrev.com/ebd02bafbf4a71ca89c81dd2d27a1319a4e5911a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53abbddc5532fba525abe5a6a048502786df197b

commit 53abbddc5532fba525abe5a6a048502786df197b
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 07 17:28:05 2017

Remove js-test from biquad-tail.html test

Inadvertently left in js-test.js, but it's not used anymore.  Remove
it.

TBR=hongchan@chromium.org
BUG= 687307 
TEST=biquad-tail.html

Review-Url: https://codereview.chromium.org/2678263004
Cr-Commit-Position: refs/heads/master@{#448654}

[modify] https://crrev.com/53abbddc5532fba525abe5a6a048502786df197b/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

Comment 7 by rtoy@chromium.org, Feb 8 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment