New issue
Advanced search Search tips

Issue 687291 link

Starred by 1 user
Status: Fixed
Owner:
hinoka@chromium.org
Closed: Apr 2017
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Buildbucket property is displayed incorrectly

Project Member Reported by no...@chromium.org, Jan 31 2017 
https://luci-milo.appspot.com/buildbot/chromeos/x86-zgb-paladin/8810
displays buildbucket build property as https://cr-buildbucket.appspot.com/b/8989365383602477376
but it must be 
{"build": {"bucket": "master.chromeos", "created_by": "user:446450136466-mko2u1g65l7iqsos5c09tni364ejqg75@developer.gserviceaccount.com", "created_ts": "1485470135092840", "id": "8989365383602477376", "lease_key": "1461842975", "tags": ["build_type:paladin", "buildset:cbuildbot/master/master-paladin/1286680", "cbb_config:x86-zgb-paladin", "cbb_master_build_id:1286680", "master:False"]}}
see the buildbot page https://uberchromegw.corp.google.com/i/chromeos/builders/x86-zgb-paladin/builds/8810

perhaps can be fixed by fixing issue 632898

Comment 1 by no...@chromium.org, Jan 31 2017

Components: Infra>Platform>Milo

Comment 2 by hinoka@chromium.org, Feb 27 2017 

That was actually an intentional stylistic choice, because an unstructured JSON blob is difficult for humans to parse.

wdyt about breaking it out into structured "properties"?

Comment 3 by no...@chromium.org, Feb 27 2017 

this property is not designed for users to parse, it is used by buildbot-buildbucket integration code, but I look at it sometimes. 

I think breaking it out does is not worth it. It'd require risky changes to buildbot-buildbucket integration. Also it seems it would hide a bug in milo which this issue is about. Let's scope this issue to the reason why the property is shown incorrectly.

Comment 4 by hinoka@chromium.org, Feb 27 2017

Owner: hinoka@chromium.org
Status: Started (was: Untriaged)
Talked offline, the solution will be to parse the properties and render pretty printed JSON if a JSON object is detected.

Comment 5 by no...@chromium.org, Mar 20 2017

Components: Infra>Platform>Milo>Buildbot

Comment 6 by no...@chromium.org, Mar 20 2017

Components: -Infra>Platform>Milo
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/0a0dba06054fdac1c08b08676414f6cf1188c8a8

commit 0a0dba06054fdac1c08b08676414f6cf1188c8a8
Author: hinoka <hinoka@google.com>
Date: Thu Apr 13 21:15:47 2017

Milo: Print raw json for buildbot build properties

Also remove the buildbucket -> URL conversion.

BUG= 687291 

Review-Url: https://codereview.chromium.org/2718373004

[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/buildbot/build.go
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/buildbot/expectations/CrWinGoma.30608.build.json
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/common/funcs.go
[add] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/static/buildbot/css/default.css
[modify] https://crrev.com/0a0dba06054fdac1c08b08676414f6cf1188c8a8/milo/appengine/frontend/templates/pages/build.html

Comment 8 by hinoka@chromium.org, Apr 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment