New issue
Advanced search Search tips

Issue 687270 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Feb 2017
Cc:
jeffcarp@chromium.org
alancutter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

[WPT import] List details about test owners in WPT import CLs

Project Member Reported by qyears...@chromium.org, Jan 31 2017 
When an automatic WPT import CL updates tests and expectations, ideally we want owners of each WPT directory to review the specific tests and expectations that they own; we also may want to know who to contact for any problems or questions.

To make this easier, it would be helpful if the WPT import CL description included a list of owners and what directories they should look at. e.g. it could include a message like:

  Directory owners for changes in this CL:
  someone@chromium.org:
    wpt/foo
    wpt/bar
  someone-else@chromium.org
    wpt/baz

[This will involve changing the _cl_description method in webktpy/w3c/test_importer.py.]
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a0c33d8b44020aede5aa1c52fac85ce14b7f6e

commit e0a0c33d8b44020aede5aa1c52fac85ce14b7f6e
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Feb 10 06:06:53 2017

WPT importer: List directory owners in CL description and TBR line.

For example, if there are updates in the hr-time and html directories, this will make it so that import CL descriptions would include something like this:

  Directory owners for changes in this CL:
  jsbell@chromium.org
    external/wpt/hr-time
  dom-dev@chromium.org
    external/wpt/html

  TBR=qyearsley@chromium.org,dom-dev@chromium.org,jsbell@chromium.org

Does this seem like what we want?

BUG= 687270 

Review-Url: https://codereview.chromium.org/2684663003
Cr-Commit-Position: refs/heads/master@{#449555}

[modify] https://crrev.com/e0a0c33d8b44020aede5aa1c52fac85ce14b7f6e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/e0a0c33d8b44020aede5aa1c52fac85ce14b7f6e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d

commit 0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Feb 10 18:34:30 2017

WPT Auto-import: fix for owner list in import CLs.

This is a follow-up fix for http://crrev.com/2684663003.

The mistake was: In one part of the code I was assuming that
get_directory_owners() would return a map from owner to list of
directories, but in reality it returned a dict from owner to single
directory (string).

We want to have lists of directories, since a single import CL
will often have modifications to many directories for one owner.

This resulted in silly-looking CL descriptions like
http://crrev.com/2687343002.

BUG= 687270 

Review-Url: https://codereview.chromium.org/2684423004
Cr-Commit-Position: refs/heads/master@{#449666}

[modify] https://crrev.com/0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py
[modify] https://crrev.com/0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
[modify] https://crrev.com/0ccb652d00c6fbd072608a7bdbb9f1fbe17fd87d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Comment 3 by qyears...@chromium.org, Feb 10 2017

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
Example CL that shows what this looks like:
https://codereview.chromium.org/2687803005

Comment 4 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 5 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment