New issue
Advanced search Search tips

Issue 687269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Garbled description for manual password generation in chrome://flags

Project Member Reported by elawrence@chromium.org, Jan 31 2017

Issue description

Chrome Version: 58.2998
OS: Windows 10

What steps will reproduce the problem?
(1) Visit chrome://flags#enable-manual-password-generation

Description string is "Allow the user to manually enforce to generate password on a password field."

This doesn't seem to be correct grammatically, and the resulting string is confusing.
 

Comment 1 by kolos@chromium.org, Feb 2 2017

Status: Available (was: Untriaged)

Comment 2 by vabr@chromium.org, Feb 3 2017

Labels: Hotlist-Polish
Would "Allow the user to manually enforce generating password on a password field" be better?

The flag shows a context-menu command in all password fields, which makes Chrome generate a random password value for that field. Any suggestions for a better description?

Comment 3 Deleted

The word "enforce" is weird here. Is the idea that the user *cannot* type their own password and they *must* generate one?

If not, how about:

  "Allow Chrome to generate a password for any password field."

Or even

  "Show a 'Generate Password' option on the context menu for all password fields."


... which has the additional benefit of helping the user find the feature.

Comment 5 by kolos@chromium.org, Mar 9 2017

Owner: kolos@chromium.org
Status: Started (was: Available)
I will change the description to  "Show a 'Generate Password' option on the context menu for all password fields."

Comment 6 by kolos@chromium.org, Mar 9 2017

elawrence@: thanks for feedback, new description would help users. 

CL https://codereview.chromium.org/2740963002 
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e3dd8a2fa4956c145952fccdbf33383984419c2

commit 0e3dd8a2fa4956c145952fccdbf33383984419c2
Author: kolos <kolos@chromium.org>
Date: Thu Mar 09 13:11:33 2017

[Password Generation] Fix description of #enable-manual-password-generation flag

BUG= 687269 

Review-Url: https://codereview.chromium.org/2740963002
Cr-Commit-Position: refs/heads/master@{#455722}

[modify] https://crrev.com/0e3dd8a2fa4956c145952fccdbf33383984419c2/chrome/app/generated_resources.grd

Comment 8 by kolos@chromium.org, Mar 9 2017

Status: Fixed (was: Started)

Sign in to add a comment