New issue
Advanced search Search tips

Issue 687266 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 571580



Sign in to add a comment

During HTTP -> HTTPS credential migration the secure PasswordForm::action shouldn't change

Project Member Reported by vasi...@chromium.org, Jan 31 2017

Issue description

If the previous PasswordForm::action was an HTTPS URL then we shouldn't change it during the migration. Thus, the resulting credential will be autofilled.
An HTTP action is to be overwritten by the new HTTPS origin because we don't know the correct action.
 
Labels: Merge-Request-57
I want to merge r447502 back. It's a bug fix for the feature we are launching in M57.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4a421402e98756855f8c8a229aefea944d9637

commit fa4a421402e98756855f8c8a229aefea944d9637
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Feb 06 13:38:35 2017

Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

BUG= 687266 

Review-Url: https://codereview.chromium.org/2666043004
Cr-Commit-Position: refs/heads/master@{#447502}
(cherry picked from commit aeb4ece778671ee806942e7fe4ba57431ebea692)

Review-Url: https://codereview.chromium.org/2673393002 .
Cr-Commit-Position: refs/branch-heads/2987@{#322}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fa4a421402e98756855f8c8a229aefea944d9637/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/fa4a421402e98756855f8c8a229aefea944d9637/components/password_manager/core/browser/http_password_migrator.cc
[modify] https://crrev.com/fa4a421402e98756855f8c8a229aefea944d9637/components/password_manager/core/browser/http_password_migrator_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment