New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687261 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 696128
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 636153



Sign in to add a comment

Typ should not invoke teardownClass after every test run in single process mode

Project Member Reported by nedngu...@google.com, Jan 31 2017

Issue description

When we run typ in --jobs=1, it should not invoke teardownClass after every test run. In particular, since webgl_conformance_integration_test relies on teardownClass to close the browser, this makes the suite start & close browsers for every single test, leading to test timeout.
 
We've had this discussion before. typ does not currently run all of the tests in a class in a row, and so it is actually correct for it to be calling setupClass()/teardownClass() between each test. If your tests or timeouts are actually flaking or failing as part of this, you need to fix your tests.

Apart from that, if you want to make sure that you're calling setup/teardown as infrequently as possible, you'll just need to be smarter about how you're doing things in these methods, and use setupProcess and teardownProcess instead to ensure things are cleaned up at the end.
One possible alternative to this is to introduce fancier sharding into typ, which is something that I've been meaning to get around to for a long time (I think there's even another bug open on this somewhere), and that would give you more control over what was run where and when.
Blocking: 636153
Feel free to dedupe this bug to the bug that implements actual sharding for typ.
Labels: Build-Tools-TYP
Mergedinto: 696128
Status: Duplicate (was: Assigned)
de-duping into bug 696128 (I don't think there was a bug on file before, but there is now).

Sign in to add a comment