New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687252 link

Starred by 1 user
Status: Fixed
Owner:
edwardjung@chromium.org
Closed: Feb 2017
Cc:
maxwalker@chromium.org
█ bbergher@chromium.org
kkaluri@chromium.org
█ ainslie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Placement of generate password context menu item should be at the top

Project Member Reported by edwardjung@chromium.org, Jan 31 2017 
1) Ensure password generation is on: chrome://flags/#enable-password-generation
2) Go to a page with a password field: https://accounts.google.com/SignUp
3) Context click on the field.
4) The 'Generate password' menu item is at the bottom.

Expected to see the item at the top. Unlikely you want to use anything else other than paste. Many of the top menu items are disabled anyway.
Screen Shot 2017-01-31 at 08.45.01.png
77.0 KB View Download

Comment 1 by ainslie@chromium.org, Jan 31 2017

Cc: bbergher@chromium.org maxwalker@chromium.org

Comment 2 by bbergher@chromium.org, Feb 1 2017 

Wholeheartedly agree.

Comment 3 by edwardjung@chromium.org, Feb 14 2017

Status: Started (was: Assigned)
Some Linux build screenshots. These need the flags / experiments enabled.
Screen Shot 2017-02-13 at 16.20.19.png
160 KB View Download
Screen Shot 2017-02-13 at 16.21.04.png
169 KB View Download
Screen Shot 2017-02-13 at 16.21.38.png
180 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d68b705395f7adb0608d1898d3ceffde6583f68

commit 6d68b705395f7adb0608d1898d3ceffde6583f68
Author: edwardjung <edwardjung@chromium.org>
Date: Tue Feb 14 23:27:58 2017

Move save/generate password options to the top of the context menu

For screenshots see:
https://bugs.chromium.org/p/chromium/issues/detail?id=687252#c3

BUG= 687252 

Review-Url: https://codereview.chromium.org/2692913003
Cr-Commit-Position: refs/heads/master@{#450511}

[modify] https://crrev.com/6d68b705395f7adb0608d1898d3ceffde6583f68/chrome/browser/renderer_context_menu/render_view_context_menu.cc

Comment 5 by edwardjung@chromium.org, Feb 16 2017

Status: Fixed (was: Started)
Now in Canary
Screen Shot 2017-02-16 at 11.06.44.png
210 KB View Download

Comment 6 by kkaluri@chromium.org, Feb 16 2017

Labels: Needs-Feedback
Verified this issue in windows 10, Ubuntu 14.04 and mac 10.12.3 with chrome version #58.0.3013.3, enabled password generation flag as per comment #1

In password input field, on context clicking didn't observe any save password and generation password options.
Attaching the screencast for reference, could you please look into it and let us know your observations.

Thank You...
Issue 687252.mp4
3.2 MB View Download

Comment 7 by edwardjung@chromium.org, Feb 16 2017 

My bad, the flags you need to set are:

chrome://flags/#enable-password-force-saving
chrome://flags/#enable-manual-password-generation

Comment 8 by kkaluri@chromium.org, Feb 16 2017

Cc: kkaluri@chromium.org
Labels: -Needs-Feedback TE-Verified-M58 TE-Verified-58.0.3013.3
As per comment #7, re-verified the issue, Observed that in the password input field on context clicking ""save password" and "generate password" are shown in top of menu.
Attaching the screencast for reference.

Hence adding TE-verified labels.
Issue 687252.mp4
771 KB View Download
►

Sign in to add a comment