New issue
Advanced search Search tips

Issue 687245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 687243



Sign in to add a comment

Get Clang static analyzer working under Goma

Project Member Reported by kmarshall@chromium.org, Jan 31 2017

Issue description

It would be nice to run the analyzer at -j2000 without causing the workstation to melt down. This bug tracks the effort to get the analysis script running under Goma.
 
Blocking: 687243
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6694c0e5e6727606e83542d3d471f3967fdb0128

commit 6694c0e5e6727606e83542d3d471f3967fdb0128
Author: kmarshall <kmarshall@chromium.org>
Date: Fri Mar 10 19:47:21 2017

Remove dependency on scan-build wrapper script for analysis builds.

This CL replaces the Clang 'c++-analyzer' Perl script with logic added to the Python wrapper script. This gives us the hooks we need to run analysis builds with "gomacc" (necessary for distributed builds) and gives us a convenient place to specify analyzer config flags which aren't exposed by scan-build.

Adds a warning suppression rule which prevents the analyzer from raising false positives from stdlib code (code w/namespace "std").

Other changes:
* Modify Goma portions of the GCC toolchain GNI to build paths to
  the Clang static analyzer.
* Create an exception for ASM tool invocations, which don't play
  well with the analysis command line flags.
* Removed 'scan-build' DEP.

BUG= 687245 
R=thakis@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2667853004
Cr-Commit-Position: refs/heads/master@{#456136}

[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/DEPS
[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/build/toolchain/clang_static_analyzer_wrapper.py
[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/build/toolchain/gcc_toolchain.gni
[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/build/toolchain/nacl/BUILD.gn
[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/build/toolchain/nacl_toolchain.gni
[modify] https://crrev.com/6694c0e5e6727606e83542d3d471f3967fdb0128/docs/clang_static_analyzer.md

Status: Fixed (was: Assigned)

Sign in to add a comment