Issue metadata
Sign in to add a comment
|
"Increase Contrast" mode doesn't affect the omnibox or toolbar buttons |
||||||||||||||||||||||||
Issue descriptionChrome Version: M56beta OS: macOS 10.12.2 - In System Preferences, enable "Accessibility > Display > Increase Contrast" expected: - Omnibox should have a black stroke around it so it's easier to see - back/forward/reload buttons should have a black stroke around them so they are easier to see - Extension icons should probably have the same. actual: - Nothing changes Safari does this correctly and darkens the stroke around everything on their toolbar.
,
Feb 3 2017
,
Feb 3 2017
Note that bug 565996 is about the larger question of addressing this across our UI in the MacViews world, so this bug could be scoped to whether we want to address this before that.
,
Feb 3 2017
#3: since we think MacViews top chrome is a long way off, this bug was about fixing the problem in the Cocoa chrome, which I think will not be too difficult. Also, yoink :)
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b85e2704bd0928862b747cc19e10b95f35efef04 commit b85e2704bd0928862b747cc19e10b95f35efef04 Author: ellyjones <ellyjones@chromium.org> Date: Thu Feb 23 17:23:04 2017 cocoa: draw BackgroundGradientView separators darker in Increase Contrast mode BUG= 687227 Review-Url: https://codereview.chromium.org/2710093002 Cr-Commit-Position: refs/heads/master@{#452532} [modify] https://crrev.com/b85e2704bd0928862b747cc19e10b95f35efef04/chrome/browser/ui/cocoa/background_gradient_view.mm
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f74bb3ef462cccad2c007d934c21b730c8d9bf08 commit f74bb3ef462cccad2c007d934c21b730c8d9bf08 Author: ellyjones <ellyjones@chromium.org> Date: Thu Feb 23 17:50:18 2017 cocoa: darken toolbar buttons in Increase Contrast mode BUG= 687227 Review-Url: https://codereview.chromium.org/2710103003 Cr-Commit-Position: refs/heads/master@{#452544} [modify] https://crrev.com/f74bb3ef462cccad2c007d934c21b730c8d9bf08/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm [modify] https://crrev.com/f74bb3ef462cccad2c007d934c21b730c8d9bf08/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c766c7081a39d69bdde6f008f1c5e0dc6d4388c commit 2c766c7081a39d69bdde6f008f1c5e0dc6d4388c Author: ellyjones <ellyjones@chromium.org> Date: Thu Feb 23 17:53:52 2017 omnibox: use dark border stroke in Increase Contrast mode BUG= 687227 Review-Url: https://codereview.chromium.org/2710003003 Cr-Commit-Position: refs/heads/master@{#452546} [modify] https://crrev.com/2c766c7081a39d69bdde6f008f1c5e0dc6d4388c/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
,
Feb 23 2017
This is finally Fixed :D tomorrow's canary should have these changes. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rpop@chromium.org
, Jan 31 2017