Bisect - Output reports no perf regression on incomplete bisect. |
||||
Issue description
,
Jan 31 2017
Quick check into this. So grabbing the json and feeding it into bisect_report directly yields a bisect message about not running to completion, so I don't think that's the problem. Might be an issue with what the dashboard is using to create the report.
,
Feb 3 2017
,
Feb 13 2017
,
Feb 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8987748130700457392
,
Feb 13 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: INFRA_FAILURE The bisect was able to narrow the range, you can try running with: good_revision: 7c93dbe0d5fe53372321fa53368377ee6770405a bad_revision : 68c7a441710ebec8b3143eca64f4eb92da482737 If failures persist contact the team (see below) and report the error. Bisect Details Configuration: staging_linux_perf_bisect Benchmark : blink_perf.css Metric : StyleSheetInsert-bootstrap/StyleSheetInsert-bootstrap Revision Result N chromium@447773 91478.1 +- 9972.37 6 good chromium@447817 59922.2 +- 13361.3 6 bad chromium@447860 59832.1 +- 11369.4 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8987748130700457392 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5245016663916544 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 13 2017
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6511f58cd8335747fbf60ece826fc5a69c651b6 commit f6511f58cd8335747fbf60ece826fc5a69c651b6 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Mon Feb 13 20:54:12 2017 Roll src/third_party/catapult/ f8b3cce74..0f74810ff (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f8b3cce74375..0f74810ffcf7 $ git log f8b3cce74..0f74810ff --date=short --no-merges --format='%ad %ae %s' 2017-02-13 simonhatch If a bisect gets interrupted midway through run with an external failure, don't modify the resutlts_data['status'] to read 'failed'. The bisect_report expects the results data to be unmodified in order to correctly generate output. In this case it will now mention that the bisect wasn't able to run to completion and suggest a narrowed range to bisect on. 2017-02-13 simonhatch Dashboard - Use json.dumps on the value before passing to cache. Created with: roll-dep src/third_party/catapult BUG= 687205 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2688353004 Cr-Commit-Position: refs/heads/master@{#450079} [modify] https://crrev.com/f6511f58cd8335747fbf60ece826fc5a69c651b6/DEPS
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982640097732870624 |
||||
►
Sign in to add a comment |
||||
Comment 1 by simonhatch@chromium.org
, Jan 31 2017