New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687180 link

Starred by 1 user
Status: Fixed
Owner:
█ qiankun....@intel.com
Email to this user bounced
Closed: Feb 2017
Cc:
█ msrchandra@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 691741
Blocking:
issue 612542



Sign in to add a comment

Crash in base::debug::DebugBreak

Project Member Reported by ClusterFuzz, Jan 31 2017

Comment 1 by msrchandra@chromium.org, Jan 31 2017

Cc: msrchandra@chromium.org
Components: Internals>GPU>Internals
Labels: Test-Predator-Correct-CLs
Owner: qiankun....@intel.com
Status: Assigned (was: Untriaged)
Assigning to the concern owner from predator results --
The result is a list of CLs that change the crashed files. 

Author: qiankun.miao
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/bcf132827ebd0436fd3620bbda4cbcf3febdc161
Time: Sat Dec 17 03:43:45 2016
Lines 270-278 of file gles2_cmd_copy_texture_chromium.cc which potentially caused crash are changed in this cl (frame #5, "").
Minimum distance from crash line to modified line: 0. (file: gles2_cmd_copy_texture_chromium.cc, crashed on: 270, modified: 270).

@qiankun.miao -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2404c8ae0098fa7cae48db92222240293a9d2689

commit 2404c8ae0098fa7cae48db92222240293a9d2689
Author: marcheu <marcheu@chromium.org>
Date: Tue Feb 14 02:48:52 2017

Revert of Select correct copy method for DoCopySubTexture (patchset #1 id:1 of https://codereview.chromium.org/2680703003/ )

Reason for revert:
The new DoCopySubTexture causes a performance regression on WebGL on Chrome OS.

BUG= chromium:691741 
TEST=on celes, webgl performance is back to normal

Original issue's description:
> Select correct copy method for DoCopySubTexture
>
> BUG= 687180 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2680703003
> Cr-Commit-Position: refs/heads/master@{#448905}
> Committed: https://chromium.googlesource.com/chromium/src/+/a8450b810e89819add240a319586c899683dff9f

TBR=kbr@chromium.org,zmo@chromium.org,yunchao.he@intel.com,dongseong.hwang@intel.com,qiankun.miao@intel.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 687180 

Review-Url: https://codereview.chromium.org/2695833003
Cr-Commit-Position: refs/heads/master@{#450212}

[modify] https://crrev.com/2404c8ae0098fa7cae48db92222240293a9d2689/gpu/command_buffer/common/gles2_cmd_utils.cc
[modify] https://crrev.com/2404c8ae0098fa7cae48db92222240293a9d2689/gpu/command_buffer/common/gles2_cmd_utils.h
[modify] https://crrev.com/2404c8ae0098fa7cae48db92222240293a9d2689/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
[modify] https://crrev.com/2404c8ae0098fa7cae48db92222240293a9d2689/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
[modify] https://crrev.com/2404c8ae0098fa7cae48db92222240293a9d2689/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 4 by kbr@chromium.org, Feb 14 2017

Blocking: 612542

Comment 5 by kbr@chromium.org, Feb 14 2017

Blockedon: 691741

Comment 6 by kbr@chromium.org, Feb 14 2017

Status: Started (was: Assigned)
Qiankun, it looks like your CL caused a performance regression on Chrome OS. Please re-evaluate and try to re-land. Thanks.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8d862a9d32dca327a856d7f01e7b300ff4105b0

commit d8d862a9d32dca327a856d7f01e7b300ff4105b0
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Thu Feb 16 09:58:21 2017

CMAA: Avoid DCHECK failure for unsupported internalformats

CMAA implementation replies on CopyTextureCHROMIUM extension which only
supports part of ES3 formats. Skip CMAA for those unsupported formats.

BUG= 535198 ,  687180 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2697503002
Cr-Commit-Position: refs/heads/master@{#450920}

[modify] https://crrev.com/d8d862a9d32dca327a856d7f01e7b300ff4105b0/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/d8d862a9d32dca327a856d7f01e7b300ff4105b0/gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc
Project Member

Comment 9 by ClusterFuzz, Feb 17 2017 

ClusterFuzz has detected this issue as fixed in range 450877:450923.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5219421732995072

Fuzzer: libfuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: UNKNOWN
Crash Address: 0x03e900000c6b
Crash State:
  base::debug::DebugBreak
  GetFragmentShaderId
  gpu::gles2::CopyTextureCHROMIUMResourceManager::DoCopyTextureInternal
  
Sanitizer: address (ASAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=439271:439312
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=450877:450923

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95M-0F62f1zRDBr_hI4nEzom709DdTO8aq3PBgH0JCeOlcKImcd0-NELzZgKA0l2dRLAShNWGtELnpXEDnGFJLQWCu9yDVtpFA7yRVnYgaY4EU0h2aOOnXWdBo35czGbBEK7KOxEZnnYb4CRTZMZB81vFcQU3cz700U8X9tYZeeL5zdMrEXE6nd_a8H0uHupuUYZ3zfWFVB7-3-Gn4K7p6AjPzv1M7-LfqasPylacbVA6uaRqmCHdBJjB7-oMIrw0QEQRHv3pMWGKJLAMjevjw1jPed99ygzbjiCgTHGMQ70jsMYQSyTpSKuHLJMFlK-9eYFqpisIjYJHGhFUy2u2HHBXuf5Er0WhoC8qRnwxlS54tAgNw?testcase_id=5219421732995072


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 10 by qiankun....@intel.com, Feb 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment