Consider adding UseCounters specific for extensions |
|||||
Issue descriptionIn issue 652336 I updated the new UseCounters to not track usage from internal and extension pages. In some rare cases (like the DeprecatedFlexboxChromeExtension UseCounter), extensions are specifically what we want to see. Perhaps it IS worth adding a separate histogram to track usage specifically inside extension URLs?
,
Apr 3 2017
Luna, I think what we should do here is add at least one new histogram - Blink.UseCounter.Extensions.Features which we switch to using instead of Blink.UseCounter.Features in UseCounter::didCommitLoad if the URL is a chrome-extension:// URL (instead of disabling reporting completely).
,
Apr 6 2017
,
May 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc32d83f891bf73c8ce299d6813baf812907a8c8 commit fc32d83f891bf73c8ce299d6813baf812907a8c8 Author: lunalu <lunalu@chromium.org> Date: Sat May 20 04:25:28 2017 Adding UseCounter specific for extensions Replaced Blink.UseCounter.Features by Blink.UseCounter.Extensions.Features when URL protocol is chrome-extension:// BUG= 687169 Review-Url: https://codereview.chromium.org/2796283005 Cr-Commit-Position: refs/heads/master@{#473409} [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/base/test/histogram_tester.cc [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/base/test/histogram_tester.h [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/third_party/WebKit/Source/core/frame/UseCounterTest.cpp [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/third_party/WebKit/Source/platform/testing/HistogramTester.cpp [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/third_party/WebKit/Source/platform/testing/HistogramTester.h [modify] https://crrev.com/fc32d83f891bf73c8ce299d6813baf812907a8c8/tools/metrics/histograms/histograms.xml
,
May 23 2017
,
Jul 18 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mkwst@chromium.org
, Jan 31 2017