New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687167 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Feb 2017
Cc:
mvanouwe...@chromium.org
█ nepper@chromium.org
fi...@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 658647


Sign in to add a comment

Remove the NTPSuggestionsSectionDismissal flag

Project Member Reported by dgn@chromium.org, Jan 31 2017 
In issue 658647 the feature was enabled by default on M56 without any related Finch config for holdback etc. As M56 is going to stable soon, I plan to remove the flag in M58

The flag was added in https://codereview.chromium.org/2440673002/, and enabled by default in https://codereview.chromium.org/2446653002

+nepper@, finkm@ for FYI
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1764521fd144201e6dbb5514ad8967b50c035393

commit 1764521fd144201e6dbb5514ad8967b50c035393
Author: dgn <dgn@chromium.org>
Date: Wed Feb 01 13:17:17 2017

[NTP Client] Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag

BUG= 687167 

Review-Url: https://codereview.chromium.org/2667803005
Cr-Commit-Position: refs/heads/master@{#447499}

[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/components/ntp_snippets/features.cc
[modify] https://crrev.com/1764521fd144201e6dbb5514ad8967b50c035393/components/ntp_snippets/features.h

Comment 2 by dgn@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment