Add a "chassis" hardware identifier and use it instead of customization_id. |
|||||||||||
Issue descriptionCurrently many systems use SERIES part from customization_id to identify hardware difference, but this is really wrong because of few reasons: 1. customization_id was designed for LOEM in format LOEMID[-SERIES] that SERIES is really optional, and may be duplicated. 2. customization_id was provisioned in very end of factory flow that devices must run without it during most of the factory flow. 3. There's no clear definition for how SERIES was named. By the new Zerg+LOEM model, we'll see the need of an identifier being more and more important that a real hardware GPIO pin should be introduced in future. Before that, we want to start the migration of programs accessing (and parsing) customization_id directly into a more portable form. The proposal is a new command: "mosys platform chassis". For backward compatible, it'll start as printing SERIES from customization_id, and may become any implementation in future. Any components that needs to read chassis-specific info, for example audio table, touchpad firmware, touchscreen firmware, stylues, or WiFi, should read this instead of customization_id. Design doc reference: go/cros-chassis-id
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/edf3fb099168de7369331b76f13a19309e34ae3e commit edf3fb099168de7369331b76f13a19309e34ae3e Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 03 07:31:15 2017 mosys: Add "chassis" in platform command. The new "chassis" will provide an identifier for device chassis, which may be used to finding right configuration related to system assembly difference, for example audio speaker, Wi-Fi, Touchpad, ... etc. For backward compatible, chassis will try to read from VPD "customization_id" (format: LOEMID-SERIES), using the "SERIES" part from it; otherwise none. BRANCH=none BUG= chromium:687149 TEST=vpd -d customization_id; reboot mosys platform chassis # prints nothing. vpd -s customization_id=OEM_BLAH; reboot mosys platform chassis # prints BLAH Change-Id: Ie0f6bb0f931ffa2e293d86db10eceafe1d228865 Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433625 Reviewed-by: David Hendricks <dhendrix@chromium.org> [modify] https://crrev.com/edf3fb099168de7369331b76f13a19309e34ae3e/core/command/platform.c [modify] https://crrev.com/edf3fb099168de7369331b76f13a19309e34ae3e/include/mosys/platform.h [modify] https://crrev.com/edf3fb099168de7369331b76f13a19309e34ae3e/lib/misc/probe.c [modify] https://crrev.com/edf3fb099168de7369331b76f13a19309e34ae3e/include/lib/probe.h
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786 commit e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 06 04:55:50 2017 mosys: Add "chassis" in platform command. The new "chassis" will provide an identifier for device chassis, which may be used to finding right configuration related to system assembly difference, for example audio speaker, Wi-Fi, Touchpad, ... etc. For backward compatible, chassis will try to read from VPD "customization_id" (format: LOEMID-SERIES), using the "SERIES" part from it; otherwise none. BRANCH=none BUG= chromium:687149 TEST=vpd -d customization_id; reboot mosys platform chassis # prints nothing. vpd -s customization_id=OEM_BLAH; reboot mosys platform chassis # prints BLAH Signed-off-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/433625 Original-Reviewed-by: David Hendricks <dhendrix@chromium.org> Change-Id: Ie0f6bb0f931ffa2e293d86db10eceafe1d228865 Reviewed-on: https://chromium-review.googlesource.com/438128 [modify] https://crrev.com/e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786/core/command/platform.c [modify] https://crrev.com/e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786/include/mosys/platform.h [modify] https://crrev.com/e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786/lib/misc/probe.c [modify] https://crrev.com/e5ee7fdcb4771e6b6ced7c4ec6506e086e78e786/include/lib/probe.h
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/ee7da33637d578eef505243fa780a1dbba83f64f commit ee7da33637d578eef505243fa780a1dbba83f64f Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 06 04:55:54 2017 mosys: Add "chassis" in platform command. The new "chassis" will provide an identifier for device chassis, which may be used to finding right configuration related to system assembly difference, for example audio speaker, Wi-Fi, Touchpad, ... etc. For backward compatible, chassis will try to read from VPD "customization_id" (format: LOEMID-SERIES), using the "SERIES" part from it; otherwise none. BRANCH=none BUG= chromium:687149 TEST=vpd -d customization_id; reboot mosys platform chassis # prints nothing. vpd -s customization_id=OEM_BLAH; reboot mosys platform chassis # prints BLAH Signed-off-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/433625 Original-Reviewed-by: David Hendricks <dhendrix@chromium.org> Change-Id: Ie0f6bb0f931ffa2e293d86db10eceafe1d228865 Reviewed-on: https://chromium-review.googlesource.com/438146 [modify] https://crrev.com/ee7da33637d578eef505243fa780a1dbba83f64f/core/command/platform.c [modify] https://crrev.com/ee7da33637d578eef505243fa780a1dbba83f64f/include/mosys/platform.h [modify] https://crrev.com/ee7da33637d578eef505243fa780a1dbba83f64f/lib/misc/probe.c [modify] https://crrev.com/ee7da33637d578eef505243fa780a1dbba83f64f/include/lib/probe.h
,
Feb 6 2017
Note the goal is to migrate reef & gru boards to use new "chassis", and leave all old projects with legacy "customization_id".
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/af5bd740728c10cb5075e1c150d8bf4a061c1742 commit af5bd740728c10cb5075e1c150d8bf4a061c1742 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 06 11:15:54 2017 audio-config: Change hacks by customization_id to "mosys platform chassis". Device difference should be identified by the new unified "chassis id" provided by mosys. In the future the command may return values from hardware GPIO settings, but for legacy devices for backward compatibility the command is returning SERIES part of VPD customization_id. When customization_id is not provided, "mosys platform chassis" will return empty string. As a result, for some boards which expect to have a "default" value (i.e., RELM or REKS), we have to put that in the scripts. Also, RELM was using customization_id in a wrong approach - that it tries to find SERIES from LOEMID part. Ideally this should be fixed in RELM's "mosys chassis" command, but during the migration we want to do the remapping first in cras-config scripts. BUG= chromium:687149 TEST=manual: vpd -d customization_id; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/ vpd -s customization_id=A-B; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/B (reks) vpd -d customization_id; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/REKS1 vpd -s customization_id=A-B; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/B (relm) vpd -d customization_id; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/RELM vpd -s customization_id=A-B; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/B vpd -s customization_id=ACERTIFA; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/ACERTIFA vpd -s customization_id=ACERTIFA; dump_vpd_log --force; reboot; get_device_config_dir # prints /etc/cras/DASANI Change-Id: I846dbdaa9bd02c130f31f5d251bf2dc7a3a46aac Reviewed-on: https://chromium-review.googlesource.com/438025 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hsinyu Chao <hychao@chromium.org> [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-relm/chromeos-base/chromeos-bsp-relm/chromeos-bsp-relm-0.0.1-r11.ebuild [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-gnawty/chromeos-base/chromeos-bsp-gnawty/chromeos-bsp-gnawty-0.0.1-r14.ebuild [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-kefka/chromeos-base/chromeos-bsp-kefka/chromeos-bsp-kefka-0.0.1-r12.ebuild [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-kefka/chromeos-base/chromeos-bsp-kefka/files/audio-config/cras-config/get_device_config_dir [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-reks/chromeos-base/chromeos-bsp-reks/files/audio-config/cras-config/get_device_config_dir [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-terra/chromeos-base/chromeos-bsp-terra/chromeos-bsp-terra-0.0.1-r11.ebuild [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-terra/chromeos-base/chromeos-bsp-terra/files/audio-config/cras-config/get_device_config_dir [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-reks/chromeos-base/chromeos-bsp-reks/chromeos-bsp-reks-0.0.1-r15.ebuild [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-gnawty/chromeos-base/chromeos-bsp-gnawty/files/audio-config/cras-config/get_device_config_dir [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-relm/chromeos-base/chromeos-bsp-relm/files/audio-config/cras-config/get_device_config_dir [rename] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-kip/chromeos-base/chromeos-bsp-kip/chromeos-bsp-kip-0.0.1-r17.ebuild [modify] https://crrev.com/af5bd740728c10cb5075e1c150d8bf4a061c1742/overlay-kip/chromeos-base/chromeos-bsp-kip/files/audio-config/cras-config/get_device_config_dir
,
Feb 6 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/5295f78bc54901e148cff95de0e8382a2e26cc76 commit 5295f78bc54901e148cff95de0e8382a2e26cc76 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 06 11:15:54 2017
,
Feb 7 2017
Hi, Is there any on going task for migrating touchpad / touchscreen / stylus firmware to this new chassis command? Since I saw the CL for audio config is done.
,
Feb 7 2017
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_updater/+/ac38ff00fb1312f5e9955251892a2fac12ec803a commit ac38ff00fb1312f5e9955251892a2fac12ec803a Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Feb 08 06:27:06 2017 Change customization_id hacks to "mosys platform chassis". Device difference should be identified by the new unified "chassis id" provided by mosys. In the future the command may return values from hardware GPIO settings, but for legacy devices for backward compatibility the command is returning SERIES part of VPD customization_id. Function get_customization_id is removed since no one should call it directly. Function get_board_name_from_vpd is replaced by get_chassis_id, especially the "board name" may lead to confusion (i.e., the identifier in customization_id is actually "SERIES", not "Board name"). BUG= chromium:687149 TEST=None Change-Id: I4c90f06a98089ded7f03cd7888ca3211979a7a7a Reviewed-on: https://chromium-review.googlesource.com/438127 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Charlie Mooney <charliemooney@chromium.org> [modify] https://crrev.com/ac38ff00fb1312f5e9955251892a2fac12ec803a/scripts/chromeos-touch-common.sh [modify] https://crrev.com/ac38ff00fb1312f5e9955251892a2fac12ec803a/scripts/chromeos-wacom-touch-firmware-update.sh [modify] https://crrev.com/ac38ff00fb1312f5e9955251892a2fac12ec803a/scripts/chromeos-elan-touch-firmware-update.sh
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a69b64b636ca7d99decac544b11fc9cc072e2a33 commit a69b64b636ca7d99decac544b11fc9cc072e2a33 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 05:13:00 2017 gooftool: Add new 'chassis' component to replace 'customization_id'. 'customization_id' is not a real hardware component and should be replaced by 'chassis' (which may come from VPD customization_id for legacy support, or directly from hardware GPIO in future for probing results and HWID database file. And since chassis values are different from customization_id, we are not doing migration any more because: - Projects using rule-based customization_id will still work. - Projects using new style customization_id should be manually converted. BUG= chromium:687149 TEST=make test Change-Id: I6f6cc2024f0eaf3179f88c14e5f0c507c5aafd2c Reviewed-on: https://chromium-review.googlesource.com/440711 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/builder_unittest.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/README.md [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/testdata/test_db_builder.yaml [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v2/hwid_unittest.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/gooftool/probe.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/hwid_utils.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/testdata/test_builder_probe_results.yaml [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/hwid_cmdline.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/builder.py [modify] https://crrev.com/a69b64b636ca7d99decac544b11fc9cc072e2a33/py/hwid/v3/hwid_utils_unittest.py
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/42d530f9a0fdd3c8be14ba4b6fd6085815e5e578 commit 42d530f9a0fdd3c8be14ba4b6fd6085815e5e578 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 11:15:08 2017 lib: Release big lock before popen. mosys and flashrom shares same lock, and will hang if we try to execute flashrom from mosys. lib/flashrom/flashrom.c solves this by releasing and re-acquire biglock before and after spawning flashrom. Chassis identifier in probe.c also calls vpd_get_value, which may invoke 'vpd' -> 'flashrom' if cache is not available, so we have to handle locks in same way. BRANCH=None BUG= chromium:687149 TEST=VPD_IGNORE_CACHE=1 mosys platform chassis Change-Id: I2189444f75726f99a39b466377dcdba8000dcd72 Reviewed-on: https://chromium-review.googlesource.com/440566 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/42d530f9a0fdd3c8be14ba4b6fd6085815e5e578/lib/misc/probe.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/237c8474173a02fcc679fbf7dacb6fa0142b09e2 commit 237c8474173a02fcc679fbf7dacb6fa0142b09e2 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 11:17:28 2017 lib: Release big lock before popen. mosys and flashrom shares same lock, and will hang if we try to execute flashrom from mosys. lib/flashrom/flashrom.c solves this by releasing and re-acquire biglock before and after spawning flashrom. Chassis identifier in probe.c also calls vpd_get_value, which may invoke 'vpd' -> 'flashrom' if cache is not available, so we have to handle locks in same way. BRANCH=None BUG= chromium:687149 TEST=VPD_IGNORE_CACHE=1 mosys platform chassis Change-Id: I2189444f75726f99a39b466377dcdba8000dcd72 Reviewed-on: https://chromium-review.googlesource.com/440567 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/237c8474173a02fcc679fbf7dacb6fa0142b09e2/lib/misc/probe.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/9b54cab6bf9b62f6036f2055817fd3c72aca6b22 commit 9b54cab6bf9b62f6036f2055817fd3c72aca6b22 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 16:32:49 2017 lib: Release big lock before popen. mosys and flashrom shares same lock, and will hang if we try to execute flashrom from mosys. lib/flashrom/flashrom.c solves this by releasing and re-acquire biglock before and after spawning flashrom. Chassis identifier in probe.c also calls vpd_get_value, which may invoke 'vpd' -> 'flashrom' if cache is not available, so we have to handle locks in same way. BRANCH=None BUG= chromium:687149 TEST=VPD_IGNORE_CACHE=1 mosys platform chassis Change-Id: I2189444f75726f99a39b466377dcdba8000dcd72 Reviewed-on: https://chromium-review.googlesource.com/440750 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/9b54cab6bf9b62f6036f2055817fd3c72aca6b22/lib/misc/probe.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/55853fe31a718a8f337680d1cfad96f32e87396a commit 55853fe31a718a8f337680d1cfad96f32e87396a Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 18:13:37 2017 gooftool: Add new 'chassis' component to replace 'customization_id'. 'customization_id' is not a real hardware component and should be replaced by 'chassis' (which may come from VPD customization_id for legacy support, or directly from hardware GPIO in future for probing results and HWID database file. And since chassis values are different from customization_id, we are not doing migration any more because: - Projects using rule-based customization_id will still work. - Projects using new style customization_id should be manually converted. BUG= chromium:687149 TEST=make test Change-Id: I6f6cc2024f0eaf3179f88c14e5f0c507c5aafd2c Reviewed-on: https://chromium-review.googlesource.com/438286 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/builder_unittest.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/README.md [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/testdata/test_db_builder.yaml [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v2/hwid_unittest.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/gooftool/probe.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_utils.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/testdata/test_builder_probe_results.yaml [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_cmdline.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/builder.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_utils_unittest.py
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/55853fe31a718a8f337680d1cfad96f32e87396a commit 55853fe31a718a8f337680d1cfad96f32e87396a Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Feb 10 18:13:37 2017 gooftool: Add new 'chassis' component to replace 'customization_id'. 'customization_id' is not a real hardware component and should be replaced by 'chassis' (which may come from VPD customization_id for legacy support, or directly from hardware GPIO in future for probing results and HWID database file. And since chassis values are different from customization_id, we are not doing migration any more because: - Projects using rule-based customization_id will still work. - Projects using new style customization_id should be manually converted. BUG= chromium:687149 TEST=make test Change-Id: I6f6cc2024f0eaf3179f88c14e5f0c507c5aafd2c Reviewed-on: https://chromium-review.googlesource.com/438286 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/builder_unittest.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/README.md [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/testdata/test_db_builder.yaml [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v2/hwid_unittest.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/gooftool/probe.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_utils.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/testdata/test_builder_probe_results.yaml [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_cmdline.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/builder.py [modify] https://crrev.com/55853fe31a718a8f337680d1cfad96f32e87396a/py/hwid/v3/hwid_utils_unittest.py
,
Feb 24 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26 commit 7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Oct 05 00:47:38 2018 mosys: Add "chassis" in platform command. The new "chassis" will provide an identifier for device chassis, which may be used to finding right configuration related to system assembly difference, for example audio speaker, Wi-Fi, Touchpad, ... etc. For backward compatible, chassis will try to read from VPD "customization_id" (format: LOEMID-SERIES), using the "SERIES" part from it; otherwise none. BRANCH=none BUG= chromium:687149 TEST=vpd -d customization_id; reboot mosys platform chassis # prints nothing. vpd -s customization_id=OEM_BLAH; reboot mosys platform chassis # prints BLAH Change-Id: Ie0f6bb0f931ffa2e293d86db10eceafe1d228865 Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/433625 Reviewed-by: David Hendricks <dhendrix@chromium.org> (cherry picked from commit edf3fb099168de7369331b76f13a19309e34ae3e) Reviewed-on: https://chromium-review.googlesource.com/c/1263587 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26/core/command/platform.c [modify] https://crrev.com/7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26/include/mosys/platform.h [modify] https://crrev.com/7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26/lib/misc/probe.c [modify] https://crrev.com/7cb8f63b046c4c330b7f333e3f4e6cb3ea0d6b26/include/lib/probe.h |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by moch@chromium.org
, Jan 31 2017