New issue
Advanced search Search tips

Issue 687132 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove code and resources made unnecessary by the enabling by default of the iPad Tab Switcher.

Project Member Reported by jif@chromium.org, Jan 31 2017

Issue description

Non exhaustive list of things to remove:
All the experiment-related methods/constants
Code in the TabStripControllr
The button in the tab strip to toggle between incognito and non incognito
The iPad sized Material design paper like background images.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fed8128470bd4107aedd4faa9fbb0d319b355af

commit 7fed8128470bd4107aedd4faa9fbb0d319b355af
Author: jif <jif@chromium.org>
Date: Wed Feb 08 13:15:25 2017

Removing iPad Tab Switcher experimental flag.

This CL should cause no behavior change compared to having
|IsTabSwitcherEnabled| always return true.

Note:
tabstrip_switch*.png , IDS_IOS_SWITCH_BROWSER_MODE_LEAVE_INCOGNITO,
and IDC_SWITCH_BROWSER_MODES will be removed when I'll clean up the
tab_strip_controller, in a separate CL.

BUG= 687132 

Review-Url: https://codereview.chromium.org/2660143002
Cr-Commit-Position: refs/heads/master@{#448972}

[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/chrome_switches.cc
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/chrome_switches.h
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/resources/Settings.bundle/Experimental.plist
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/snapshots/snapshot_cache_internal.h
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/main/browser_view_wrangler.h
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/main/browser_view_wrangler.mm
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/BUILD.gn
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/OWNERS
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_controller.h
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_controller.mm
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_controller_testing.h
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_controller_unittest.mm
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_toolbar_controller.h
[delete] https://crrev.com/2c41fd7827b4aa5a485f5ffbb8b6a26014374e6c/ios/chrome/browser/ui/no_tabs/no_tabs_toolbar_controller.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/tabs/tab_strip_egtest.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/test/BUILD.gn
[modify] https://crrev.com/7fed8128470bd4107aedd4faa9fbb0d319b355af/ios/chrome/test/app/tab_test_util.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be26050c964a17ced5964a2508461ec780048a33

commit be26050c964a17ced5964a2508461ec780048a33
Author: jif <jif@chromium.org>
Date: Tue Mar 07 19:01:51 2017

Remove toggle button code from Tab Strip.

The button to toggle between incognito and non incognito is not used anymore.

This CL:
* removes the code that handled that button.
* renames the Tab Switcher button from _tabSwitcherToggleButton to
|_tabSwitcherButton|, as well as the other companion variables.
* fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle
button was considered, not the presence of the tab switcher button.

BUG= 687132 

Review-Url: https://codereview.chromium.org/2714003003
Cr-Commit-Position: refs/heads/master@{#455166}

[modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/BUILD.gn
[delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_switch@2x~ipad.png
[delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_switch~ipad.png
[delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_switch@2x~ipad.png
[delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_switch~ipad.png
[modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/tab_strip_controller.mm

Comment 3 by cma...@chromium.org, Mar 10 2017

Components: UI>Browser>Mobile>TabSwitcher

Comment 4 by pkl@chromium.org, Mar 26 2018

Hi, jif: Are there further work to be done here? Should I close this as Fixed?

Comment 5 by jif@google.com, Apr 3 2018

You can close this as fixed.
Owner: ----
Status: Untriaged (was: Started)
jif@ is no longer on the team. Releasing his bugs.
Cc: thegreenfrog@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)
Tab Grid will like cause a lot of the old code to go away.
Status: WontFix (was: Assigned)
Closing bugs for older tab switcher UIs.

Sign in to add a comment