Remove code and resources made unnecessary by the enabling by default of the iPad Tab Switcher. |
|||||
Issue descriptionNon exhaustive list of things to remove: All the experiment-related methods/constants Code in the TabStripControllr The button in the tab strip to toggle between incognito and non incognito The iPad sized Material design paper like background images.
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be26050c964a17ced5964a2508461ec780048a33 commit be26050c964a17ced5964a2508461ec780048a33 Author: jif <jif@chromium.org> Date: Tue Mar 07 19:01:51 2017 Remove toggle button code from Tab Strip. The button to toggle between incognito and non incognito is not used anymore. This CL: * removes the code that handled that button. * renames the Tab Switcher button from _tabSwitcherToggleButton to |_tabSwitcherButton|, as well as the other companion variables. * fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle button was considered, not the presence of the tab switcher button. BUG= 687132 Review-Url: https://codereview.chromium.org/2714003003 Cr-Commit-Position: refs/heads/master@{#455166} [modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/BUILD.gn [delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_switch@2x~ipad.png [delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_switch~ipad.png [delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_switch@2x~ipad.png [delete] https://crrev.com/8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f/ios/chrome/browser/ui/tabs/resources/tabstrip_switch~ipad.png [modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/tab_strip_controller.h [modify] https://crrev.com/be26050c964a17ced5964a2508461ec780048a33/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
,
Mar 10 2017
,
Mar 26 2018
Hi, jif: Are there further work to be done here? Should I close this as Fixed?
,
Apr 3 2018
You can close this as fixed.
,
Aug 17
jif@ is no longer on the team. Releasing his bugs.
,
Aug 20
Tab Grid will like cause a lot of the old code to go away.
,
Oct 2
Closing bugs for older tab switcher UIs. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 8 2017