New issue
Advanced search Search tips

Issue 687116 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

web-platform-tests "Assigning null to table.caption" fails

Project Member Reported by zcorpan@gmail.com, Jan 31 2017

Issue description

http://w3c-test.org/html/semantics/tabular-data/the-table-element/caption-methods.html

> Fail	Assigning null to table.caption	Failed to set the 'caption' property on 'HTMLTableElement': The new child element is null.

Test was added in https://github.com/w3c/web-platform-tests/pull/1314

The relevant change to the HTML standard seems to be

https://github.com/whatwg/html/commit/e49cdf03bf281b448deace4c75113df9f1f0b17c

https://www.w3.org/Bugs/Public/show_bug.cgi?id=24263

This particular subtest passes in Gecko and WebKit; fails in Chromium 58.0.2998.0 canary.
 

Comment 1 by tkent@chromium.org, Feb 2 2017

Cc: -tkent@chromium.org
Labels: Hotlist-Interop
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1d24823dbc613529ee4f21269aec33ae0dea2a

commit 1b1d24823dbc613529ee4f21269aec33ae0dea2a
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 09 04:26:35 2017

Setting null to caption/tHead IDL attributes should not throw.

Implementations of these setters should do nothing if null is passed.

Also, this CL changes the first argument of EnsurePreInsertionValidity()
to |const Node&|. Binding layer ensures that it's not null.

Bug:  687116 ,  730412 
Change-Id: I34f867458a07139c8e9f949b791ad1567a8f7de9
Reviewed-on: https://chromium-review.googlesource.com/527837
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478200}
[delete] https://crrev.com/1ee189bd85e14ad9bedca7946d43b5054fe760af/third_party/WebKit/LayoutTests/external/wpt/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/tabular-data/the-table-element/tHead-expected.txt
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/LayoutTests/html/tabular_data/table_exceptions-expected.txt
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/LayoutTests/html/tabular_data/table_exceptions.html
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/1b1d24823dbc613529ee4f21269aec33ae0dea2a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Comment 3 by tkent@chromium.org, Jun 9 2017

Labels: M-61
Status: Fixed (was: Available)

Sign in to add a comment