New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 687106 link

Starred by 3 users
Status: Fixed
Owner:
sprang@chromium.org
Closed: Mar 2017
Cc:
sprang@chromium.org
█ emadomara@chromium.org
webrtc-network-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M57: WebRTC screencontent simulcast mode

Project Member Reported by sprang@chromium.org, Jan 31 2017 
A special simulcast mode for simulcast screen content (enabled via a field trial) was landed in webrtc but was reverted due to bot breakage. The reland missed the cut, but we would really like to get this into M57 so that we can gather stats for it, as we plan to add things on top of this in M58.

The reland was webrtc r16299 (https://codereview.webrtc.org/2641133002/).
It was rolled into chrome at r446972 (https://codereview.chromium.org/2665643002), which is included in the canary builds.

Would really appreciate if we could land this on the M57 branch.

Comment 1 by gov...@chromium.org, Jan 31 2017 

Is this applicable to All OSes or any specific OS?

Comment 2 by gov...@chromium.org, Feb 1 2017 

Also will this be a safe merge to M57?

Comment 3 by sprang@chromium.org, Feb 1 2017

Labels: OS-All
It technically applies to all platforms, but it is geared towards the desktop use case.

I would consider it safe, since the default (field trial off) will essentially be a noop.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 1 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2017

Labels: merge-merged-57
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/71394677e4dc343ca5c0f996037207a9bd9616c9

commit 71394677e4dc343ca5c0f996037207a9bd9616c9
Author: Erik Språng <sprang@webrtc.org>
Date: Wed Feb 01 13:42:59 2017

Merge to 57: Add experimental simulcast screen content mode

This is a cherry pick of https://codereview.webrtc.org/2641133002/

BUG=webrtc:4172,  chromium:687106 
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2660403007 .
Cr-Commit-Position: refs/branch-heads/57@{#2}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}

[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/simulcast.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/simulcast.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/media/engine/webrtcvideoengine2_unittest.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc
[modify] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/video_codec_initializer.cc
[add] https://crrev.com/71394677e4dc343ca5c0f996037207a9bd9616c9/webrtc/modules/video_coding/video_codec_initializer_unittest.cc

Comment 6 by gov...@chromium.org, Feb 1 2017

Labels: -Merge-Approved-57
Per comment #5 this is already merged to M57. Hence, removing "Merge-Approved-57" label. Thank you.

Comment 7 by anatolid@chromium.org, Mar 31 2017

Owner: sprang@chromium.org
Status: Started (was: Untriaged)
Can this be closed now?

Comment 8 by sprang@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment