Dismissing "That's all for now" dismisses the next section title. |
|||
Issue descriptionChrome Version: 58.0.2997.0 What steps will reproduce the problem? (1) Find 2 non-empty sections one right after another. (2) Dismiss all suggestions in the upper section. (3) Observe "That's all for now card". (4) Start dismissing "That's all for now card". (5) Dismiss the card. What is the expected result? The next section title does not move and stays on the screen. What happens instead? The next section title moves with the card and then becomes dismissed.
,
Jan 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea8c007ce51f08fcc6429be7957e3d75627d8e9 commit 3ea8c007ce51f08fcc6429be7957e3d75627d8e9 Author: dgn <dgn@chromium.org> Date: Tue Jan 31 18:31:24 2017 [NTP Client] Handle optional item in group dismissal Makes the suggestion section properly dismiss a single item when the it does not show an action item. BUG= 687092 Review-Url: https://codereview.chromium.org/2662293002 Cr-Commit-Position: refs/heads/master@{#447276} [modify] https://crrev.com/3ea8c007ce51f08fcc6429be7957e3d75627d8e9/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/3ea8c007ce51f08fcc6429be7957e3d75627d8e9/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
,
Jan 31 2017
,
Feb 2 2017
Verified in M58-58.0.3000.0 build |
|||
►
Sign in to add a comment |
|||
Comment 1 by dgn@chromium.org
, Jan 31 2017Status: Started (was: Untriaged)