New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687079 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Popup blocker bubble is misaligned from popup icon in https://permission.site/

Reported by dmascare...@etouch.net, Jan 31 2017

Issue description

Chrome Version:57.0.2987.19 (Official Build) (64-bit) Revision d94cb0717590151019fcbaf56f450eb3a09ca344-refs/branch-heads/2987@{#209}
OS: Mac (10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome and navigate to https://permission.site/
2. Click on ‘Popup (delayed 2 seconds) such that popup blocker icon is seen in omnibox ,click on the icon.
3. Observe bubble.

Actual: Popup blocker bubble is seen misaligned after step 3.
Expected: Popup blocker bubble should be at proper location/position.

This is regression issue, broken in ‘M 57’ and below is manual bisect info:
Good build:57.0.2958.0
Bad build:57.0.2959.0

Note: Issue is not seen on Windows and Linux OS.

 
Actual.png
283 KB View Download
Expected.png
268 KB View Download
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: lgrey@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac10.12.2 and below are the per revision bisect details for the same:

Good build:57.0.2958.0--Revision-439976
Bad build:57.0.2959.0--Revision-440307

You are probably looking for a change made after 440205 (known good), but no later than 440206 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/81a0e72b623acb1710b279d072ba0272ad8234bf..fdc6c66162e754b82e2d7f5db09767733d49005c

Possible suspect:
https://chromium.googlesource.com/chromium/src/+/fdc6c66162e754b82e2d7f5db09767733d49005c

Review-Url: https://codereview.chromium.org/2594543004

lgrey@ Assigning to you, kindly have a look into it.

Thanks.

Comment 2 Deleted

A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Comment 4 Deleted

sdy@ and thakis@ (possible suspect CL reviewers - https://codereview.chromium.org/2594543004), can anyone of you PTAL as this bug is marked as M57 Stable blocker and lgrey@ is OOO Parental Leave. Thank you.

Comment 6 by sdy@chromium.org, Feb 9 2017

Looking.

Comment 7 by sdy@chromium.org, Feb 10 2017

I can't reproduce this on Canary (58.0.3007.0) or on the specific revision mentioned in #1 (57.0.2959.0). I'm going to keep trying, but am I doing something wrong? Screen recording attached.
permission_bubble_alignment_wfm.mov
4.8 MB Download
sdy@: Please refer the attached screen cast for the reproducing the issue.
Issue persists in Canary 58.0.3013.0 and Beta 57.0.2987.54.
687079_Feb_16.mp4
870 KB View Download

Comment 9 by gov...@chromium.org, Feb 16 2017

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Status: Untriaged (was: Assigned)
Back to triage given that lgrey is away and this is releaseblock-stable

Comment 11 by sdy@chromium.org, Feb 16 2017

Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
I can deal with this, just verifying the regression.

Comment 12 by sdy@chromium.org, Feb 16 2017

Cc: -sdy@chromium.org

Comment 13 by sdy@chromium.org, Feb 21 2017

Cc: sdy@chromium.org
Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: lgrey@chromium.org
lgrey@ is back \o/.

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.

Comment 15 by lgrey@chromium.org, Feb 22 2017

Sorry for the delay on this, I just got back from parental leave yesterday.

There's a fix waiting on owner's review at https://codereview.chromium.org/2706273004/
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac719a4ad8dd599eea270444f37a3cc3a05be4a5

commit ac719a4ad8dd599eea270444f37a3cc3a05be4a5
Author: lgrey <lgrey@chromium.org>
Date: Wed Feb 22 19:16:57 2017

[Mac] Fix bubble origin for animated Omnibox decorations

Conceptually similar to the code removed in https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG= 687079 

Review-Url: https://codereview.chromium.org/2706273004
Cr-Commit-Position: refs/heads/master@{#452160}

[modify] https://crrev.com/ac719a4ad8dd599eea270444f37a3cc3a05be4a5/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm

Labels: TE-Verified-58.0.3021.0 TE-Verified-M58
Verified this issue on Mac OS 10.12 using chrome latest Dev M58-58.0.3021.0 by following steps mentioned in the original comment, Observed the popup blocker bubble is aligned properly as expected. Hence adding TE-Verified label for M57.


687079.mp4
645 KB View Download

Comment 18 by lgrey@chromium.org, Feb 23 2017

Labels: Merge-Request-57
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 23 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb17964584d04aecd6c3fd8217c6f0d1d4313831

commit eb17964584d04aecd6c3fd8217c6f0d1d4313831
Author: Sidney San Martín <sdy@chromium.org>
Date: Thu Feb 23 19:33:28 2017

[Mac] Fix bubble origin for animated Omnibox decorations

Conceptually similar to the code removed in https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG= 687079 

Review-Url: https://codereview.chromium.org/2706273004
Cr-Commit-Position: refs/heads/master@{#452160}
(cherry picked from commit ac719a4ad8dd599eea270444f37a3cc3a05be4a5)

Review-Url: https://codereview.chromium.org/2716503005 .
Cr-Commit-Position: refs/branch-heads/2987@{#664}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/eb17964584d04aecd6c3fd8217c6f0d1d4313831/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm

Labels: TE-Verified-57.0.2987.88 TE-Verified-M57
Verified the issue on Mac 10.12.3 and 57.0.2987.88 its working fine now.
Please find the screen cast for the same.
Hence added respective TE-verified labels to it.

sdy@/lgrey@: Could you please update the status to Fixed/Verified.
687079_Mar_1.mp4
558 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment