Non-Regression : Focus is seen missing on 'Cancel selection' option in Files App on Tabbing |
||||||||||
Issue descriptionChrome Version: 58.0.2994.0/9236.0.0 dev-channel Paine, Falco, Kip OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download image (2)Now go to Files App-> select image so that 'Cancel selection','Open','Delete' options are seen (3)Click on 'Tab' Button and observe focus is not seen on 'Cancel selection' option(Please refer 'Actual_NoFocus' Video) Note: When focus is on selected image click on tab and then click 'enter' button and observe image selection is canceled i.e. we can see 'Cancel selection' option is working but only focus is seen missing (Please refer 'Actual_Enter' video) Expected: Focus should be seen on 'Cancel selection' option in Files App on Tabbing Actual: Instead Focus is seen missing This is Non-Regression Issue seen from M-54 @fukino: Please confirm the issue
,
Feb 24 2018
,
Feb 28 2018
,
Feb 28 2018
,
Mar 14 2018
Technically there is focus, but the "cancel" button is not highlighted as having focus.
,
Apr 12 2018
Luciano; is this something you've seen/already fixed? :)
,
Apr 13 2018
,
Apr 16 2018
This issue is because the "Cancel selection" is a <paper-button> and the other buttons are just <button>. I'm fixing the style to also apply to <paper-button>.
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e3f56e4350cb3add404a330767a0e787f92d04b commit 7e3f56e4350cb3add404a330767a0e787f92d04b Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Apr 17 09:12:37 2018 Fix 'Cancel selection' button style when focused This button is <paper-button> in contrast to other buttons that are just <button> so the style wasn't applying to it. Add "menu-button" CSS class to all buttons within div.dialog-header so they can share similar style. Bug: 687077 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1426891c17f734e8d4ce81cdec48c23cdefcbbdd Reviewed-on: https://chromium-review.googlesource.com/1013844 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#551283} [modify] https://crrev.com/7e3f56e4350cb3add404a330767a0e787f92d04b/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/7e3f56e4350cb3add404a330767a0e787f92d04b/ui/file_manager/file_manager/main.html
,
Apr 17 2018
The patch above fixes this issue. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by weifangsun@chromium.org
, Nov 16 2017