New issue
Advanced search Search tips

Issue 687072 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Wrong enctype=text/plain implementation

Project Member Reported by tkent@chromium.org, Jan 31 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Open http://w3c-test.org/html/semantics/forms/form-submission-0/submit-entity-body.html

What is the expected result?
No FAILs

What happens instead?
There are three FAILs.

Please use labels and text to provide additional information.

https://html.spec.whatwg.org/multipage/forms.html#text/plain-encoding-algorithm
> 6. Append a U+000D CARRIAGE RETURN (CR) U+000A LINE FEED (LF) character pair to result.

The current code in FormDataEncoder::addKeyValuePairAsFormData() looks to add CRLF only between pairs.

 

Comment 1 by tkent@chromium.org, Jan 31 2017

Summary: Wrong enctype=text/plain implementation (was: enctype=text/plain)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b

commit 76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b
Author: loorongjie <loorongjie@gmail.com>
Date: Fri Feb 10 14:01:50 2017

Fix enctype=text/plain implementation

Append CRLF after each data entry instead of only in between pairs.

R=tkent@chromium.org,jochen@chromium.org
BUG= 687072 

Review-Url: https://codereview.chromium.org/2687863002
Cr-Commit-Position: refs/heads/master@{#449608}

[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/AUTHORS
[delete] https://crrev.com/937fd873bf0791a2b402a7c32a7b29749656fec8/third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/form-submission-0/submit-entity-body-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/post-multiple-items-text-plain-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/post-text-plain-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/LayoutTests/http/tests/misc/resources/form-post-textplain.php
[modify] https://crrev.com/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

Comment 3 by tkent@chromium.org, Feb 10 2017

Labels: M-58
Status: Fixed (was: Available)

Sign in to add a comment