New issue
Advanced search Search tips

Issue 687057 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"commit-git-patch" step in run_presubmit should not cause build failure

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 31 2017

Issue description

"commit-git-patch" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is not infrastructure-related (e.g. flaky test), please add Sheriff-Chromium label and change issue status to Untriaged. When done, please remove the issue from Trooper Bug Queue by removing the Infra-Troopers label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyGwsSBUZsYWtlIhBjb21taXQtZ2l0LXBhdGNoDA.



This flaky test/step was previously tracked in  issue 679863 .
 
Summary: "commit-git-patch" should not cause build failure (was: "commit-git-patch" is flaky)
This is a local operation, the first 3 failures say:

HEAD detached at origin/master
nothing to commit, working tree clean
step returned non-zero exit code: 1

This probably should just pass if it can't commit.
Components: -Tests>Flaky Infra
Labels: -Infra-Troopers
Summary: "commit-git-patch" step in run_presubmit should not cause build failure (was: "commit-git-patch" should not cause build failure)
Status: Available (was: Untriaged)
Components: -Infra Infra>Client>Chrome
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Apr 18 2017

Labels: Infra-Troopers
Detected 4 new flakes for test/step "commit-git-patch". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyGwsSBUZsYWtlIhBjb21taXQtZ2l0LXBhdGNoDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Trooper Bug Queue (unless already there).

Comment 6 by iannu...@google.com, Apr 19 2017

Um, if there's nothing to commit, then this should be treated as a patch failure right? It basically means that the CL in question was already committed.
Status: WontFix (was: Available)
I think #6 is correct, look at the last comment on the issues that caused this to fire:
https://codereview.chromium.org/2825683002 and https://codereview.chromium.org/2821563002

Looks like it's WAI?

Sign in to add a comment