New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 687020 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 759163



Sign in to add a comment

Make sure mus services report memory usage correctly

Project Member Reported by sadrul@chromium.org, Jan 31 2017

Issue description

Mus window-server, gpu, and display compositor should correctly report the memory usage to the memory-infra service. We need to measure/inspect memory usage (with tracing, for example) to make sure we are not regressing in terms of memory usage with mus.
 

Comment 1 by sadrul@chromium.org, Aug 25 2017

Blocking: 759163

Comment 2 by sadrul@chromium.org, Aug 30 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60345b63eb89379e689347ff01d7c8b52cfaa18a

commit 60345b63eb89379e689347ff01d7c8b52cfaa18a
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Wed Sep 13 17:10:15 2017

move memory_infra and tracing to the GRC service

memory_instrumentation::Coordinator is exposed by the browser service
right now, which was a temporary solution before the
resource_coordinator service was created. This CL moves it to the
resource_coordinator service.

Also, this CL exposes the tracing service, too. Later it will be used
instead of the tracing controller that lives in the browser.

Moving memory instrumentation and tracing to the resource_coordinator
service will let the service manager to register all "service"
processes to report memory usage and trace data. This is not possible
if memory instrumentation and tracing live in content_browser since it
will be a layering violation to have a dependency from
//services/service_manager to content.

BUG= 687020 , 640235 , 733165 

Change-Id: I7ea9e61430f4406fd115abd747b35a806a392469
Reviewed-on: https://chromium-review.googlesource.com/628658
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501668}
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/browser/browser_main_loop.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/child/child_thread_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/public/app/mojo/content_packaged_services_manifest.json
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_manager.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/coordination_unit/tab_signal_generator_impl.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/manifest.json
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/resource_coordinator_service.h
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/service_callbacks_impl.cc
[modify] https://crrev.com/60345b63eb89379e689347ff01d7c8b52cfaa18a/services/resource_coordinator/service_callbacks_impl.h

Cc: -mfomitchev@chromium.org
Components: -Internals>MUS Internals>Services>WindowService
Status: Fixed (was: Started)

Sign in to add a comment