New issue
Advanced search Search tips

Issue 687011 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] use BrowserPresentationConnectionProxy to send message from route to blink connection

Project Member Reported by zhaobin@chromium.org, Jan 31 2017 
https://codereview.chromium.org/2471573005/ adds BrowserPresentationConnectionProxy class. It handles message sending from blink connection -> route. Message sending in another direction, from route -> blink connection is still handled by PresentationServiceImpl, PresentationDispatcher, and PresentationController, not through proxy.

After implementing message sending from route -> blink connection, we will be able to remove

PresentationServiceImpl::ListenForConnectionMessages
PresentationServiceImpl::OnConnectionMessages

and related functions in PresentationDispatcher and PresentationServiceDelegateImpl

Comment 1 by sko...@chromium.org, Feb 9 2017

Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e086a06b613955abb1293eecef0d4c0cda0244f7

commit e086a06b613955abb1293eecef0d4c0cda0244f7
Author: imcheng <imcheng@chromium.org>
Date: Wed Jun 21 19:04:04 2017

[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG= 687011 

Review-Url: https://codereview.chromium.org/2943033003
Cr-Commit-Position: refs/heads/master@{#481265}

[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/renderer/presentation/presentation_dispatcher.h
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/e086a06b613955abb1293eecef0d4c0cda0244f7/third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Comment 3 by imch...@chromium.org, Jul 5 2017

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee9d815d9cf6434dd8b9b6a0c664a50655bcb6b

commit 3ee9d815d9cf6434dd8b9b6a0c664a50655bcb6b
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Jul 21 00:15:13 2017

[Media Router] Remove SendMessage from PresentationServiceDelegate

It is no longer used as a result of sending presentation connection
messages via the PresentationConnection interface.

Bug:  687011 
Change-Id: Ic537619a08865d33a79f3dffa29d82473d1b4e5e
Reviewed-on: https://chromium-review.googlesource.com/580049
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488510}
[modify] https://crrev.com/3ee9d815d9cf6434dd8b9b6a0c664a50655bcb6b/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/3ee9d815d9cf6434dd8b9b6a0c664a50655bcb6b/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/3ee9d815d9cf6434dd8b9b6a0c664a50655bcb6b/content/public/browser/presentation_service_delegate.h
►

Sign in to add a comment